Opened 8 years ago

Closed 6 years ago

#6188 closed (fixed)

Support for flexible URLs for complex feeds

Reported by: Guilherme M. Gondim (semente) <semente@…> Owned by: nobody
Component: contrib.syndication Version: master
Severity: Keywords: view feed rss syndication
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

If I have this in my URL configuration:

feeds = {
    'rss': RssEntriesByTagFeed,
    'atom': AtomEntriesByTagFeed,
}
urlpatterns = patterns('',
    url(
        regex  = '^tag/(?P<url>.*)/$',
        view   = 'django.contrib.syndication.views.feed',
        kwargs = dict(feed_dict=feeds)
    ),
)

...I can't access my tags feeds with tag/example/rss/ (rss is my slug, example is my param), but I can with tag/rss/example/.

I attach a patch like a suggestion for change this to support flexibles URLs for complex feeds.


Example with the new view (in patch):

    url(
        regex  = '^tag/(?P<param>[^/]+)/(?P<slug>(rss|atom))/$',
        view   = 'django.contrib.syndication.views.feed',
        kwargs = dict(feed_dict=feeds)
    ), 


Support for GET parameters would be cool.

Attachments (1)

feedview.patch (732 bytes) - added by Guilherme M. Gondim (semente) <semente@…> 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by Guilherme M. Gondim (semente) <semente@…>

comment:1 Changed 8 years ago by Simon Greenhill <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 6 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [12338]) Fixed #6188, #6304, #6618, #6969, #8758, #8989, #10334, #11069, #11973 and #12403 -- Modified the syndication framework to use class-based views. Thanks to Ben Firshman for his work on this patch.

Note: See TracTickets for help on using tickets.
Back to Top