Opened 8 years ago

Closed 7 years ago

#10334 closed (fixed)

Syndication framework calls context processors twice per item

Reported by: Ian Lewis Owned by: nobody
Component: contrib.syndication Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


The syndication framework renders title and description of items from a template which causes context_processors to be called twice per item in the feed. Even when a template is not specified the syndication framework renders a simple template "{{ obj }}" which calls context_processors needlessly and could possibly cause performance problems.

A patch is attached that calls force_unicode on the item to obtain the title and description when a template for the title or description is not provided.

Attachments (1)

syndication.patch (2.1 KB) - added by Ian Lewis 8 years ago.
Patch for the RSS framework

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Ian Lewis

Attachment: syndication.patch added

Patch for the RSS framework

comment:1 Changed 8 years ago by Jacob

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedDesign decision needed

comment:2 Changed 7 years ago by Ian Lewis

This bug is marked "Design decision needed". What kind of design decision is needed? Would the proposed solution of simply rendering the item as unicode when there is no template specified be incorrect?

comment:3 Changed 7 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [12338]) Fixed #6188, #6304, #6618, #6969, #8758, #8989, #10334, #11069, #11973 and #12403 -- Modified the syndication framework to use class-based views. Thanks to Ben Firshman for his work on this patch.

Note: See TracTickets for help on using tickets.
Back to Top