Code

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6069 closed (wontfix)

Fix auto-escaping Password-Change-Link in Admin

Reported by: anonymous Owned by: anonymous
Component: contrib.admin Version: master
Severity: Keywords: admin, escaping, sprintdec01
Cc: thomas-django@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Auto-escaping broke Password-Change link in Admin.

Attachments (2)

6777-escaping.patch (1.6 KB) - added by toke 7 years ago.
6777-escaping.2.patch (1.6 KB) - added by toke 7 years ago.
New Patch with suggestion from comment:3

Download all attachments as: .zip

Change History (15)

Changed 7 years ago by toke

comment:1 Changed 7 years ago by toke

  • Cc thomas-django@… added
  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to anonymous
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 7 years ago by anonymous

_(mark_safe('string')) looks wrong to me - I think it should be mark_safe(_('string'))

comment:3 Changed 7 years ago by anonymous

Is it a dupe from #6061? But [6781] Does not fix this issue.

comment:4 Changed 7 years ago by anonymous

  • Owner changed from anonymous to toke
  • Status changed from assigned to new

Changed 7 years ago by toke

New Patch with suggestion from comment:3

comment:5 Changed 7 years ago by anonymous

  • Summary changed from Fix auto-esacaping Password-Change-Link in Admin to Fix auto-escaping Password-Change-Link in Admin
  • Triage Stage changed from Unreviewed to Accepted

comment:6 Changed 7 years ago by toke

  • Status changed from new to assigned

comment:7 Changed 7 years ago by toke

  • Keywords admin, escaping, sprint1dec added; admin escaping removed

comment:8 Changed 7 years ago by toke

  • Keywords sprintdec1 added; sprint1dec removed

comment:9 Changed 7 years ago by anonymous

  • Owner changed from toke to anonymous
  • Status changed from assigned to new

comment:10 Changed 7 years ago by Honza_Kral

  • Keywords sprintdec01 added; sprintdec1 removed

changed sprint keyword to match the others

comment:11 Changed 7 years ago by mtredinnick

  • Resolution set to wontfix
  • Status changed from new to closed

This isn't necessary. Help text should never be auto-escaped. Is this still an issue after [6781]?

If this is still a bug on trunk, there should be some kind of template fix marking the help_text output as "safe", not a patch required to the model text.

comment:12 Changed 7 years ago by Karen Tracey <kmtracey@…>

I can't replicate the problem with trunk r6805. Help text for the password form shows up fine, with a working link.

comment:13 Changed 7 years ago by anonymous

It is indeed fixed by r6781. The Report and Fix was against r6777.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.