Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#6069 closed (wontfix)

Fix auto-escaping Password-Change-Link in Admin

Reported by: anonymous Owned by: anonymous
Component: contrib.admin Version: master
Severity: Keywords: admin, escaping, sprintdec01
Cc: thomas-django@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Auto-escaping broke Password-Change link in Admin.

Attachments (2)

6777-escaping.patch (1.6 KB) - added by Thomas Kerpe 9 years ago.
6777-escaping.2.patch (1.6 KB) - added by Thomas Kerpe 9 years ago.
New Patch with suggestion from comment:3

Download all attachments as: .zip

Change History (15)

Changed 9 years ago by Thomas Kerpe

Attachment: 6777-escaping.patch added

comment:1 Changed 9 years ago by Thomas Kerpe

Cc: thomas-django@… added
Has patch: set
Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to anonymous
Patch needs improvement: unset
Status: newassigned

comment:2 Changed 9 years ago by anonymous

_(mark_safe('string')) looks wrong to me - I think it should be mark_safe(_('string'))

comment:3 Changed 9 years ago by anonymous

Is it a dupe from #6061? But [6781] Does not fix this issue.

comment:4 Changed 9 years ago by anonymous

Owner: changed from anonymous to Thomas Kerpe
Status: assignednew

Changed 9 years ago by Thomas Kerpe

Attachment: 6777-escaping.2.patch added

New Patch with suggestion from comment:3

comment:5 Changed 9 years ago by anonymous

Summary: Fix auto-esacaping Password-Change-Link in AdminFix auto-escaping Password-Change-Link in Admin
Triage Stage: UnreviewedAccepted

comment:6 Changed 9 years ago by Thomas Kerpe

Status: newassigned

comment:7 Changed 9 years ago by Thomas Kerpe

Keywords: sprint1dec added

comment:8 Changed 9 years ago by Thomas Kerpe

Keywords: sprintdec1 added; sprint1dec removed

comment:9 Changed 9 years ago by anonymous

Owner: changed from Thomas Kerpe to anonymous
Status: assignednew

comment:10 Changed 9 years ago by Honza Král

Keywords: sprintdec01 added; sprintdec1 removed

changed sprint keyword to match the others

comment:11 Changed 9 years ago by Malcolm Tredinnick

Resolution: wontfix
Status: newclosed

This isn't necessary. Help text should never be auto-escaped. Is this still an issue after [6781]?

If this is still a bug on trunk, there should be some kind of template fix marking the help_text output as "safe", not a patch required to the model text.

comment:12 Changed 9 years ago by Karen Tracey <kmtracey@…>

I can't replicate the problem with trunk r6805. Help text for the password form shows up fine, with a working link.

comment:13 Changed 9 years ago by anonymous

It is indeed fixed by r6781. The Report and Fix was against r6777.

Note: See TracTickets for help on using tickets.
Back to Top