Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#6061 closed (fixed)

escape help_text in admin

Reported by: Peter Baumgartner Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords: escape safe help_text
Cc: sgt.hulka@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


help_text is not escaped in admin

attaching a patch against trunk

Attachments (1)

patch.diff (712 bytes) - added by Peter Baumgartner 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Peter Baumgartner

Attachment: patch.diff added

comment:1 Changed 9 years ago by Malcolm Tredinnick

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

Your bug report and patch don't match up. Do you mean that help text is being escaped when it shouldn't be? I guess so. Certainly help_text shouldn't be escaped when inserted, so the patch is correct.

comment:2 Changed 9 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [6781]) Fixed #6061 -- Don't escape help_text in the admin interface (so that it
behaves as documented). Thanks, baumer.

comment:3 Changed 9 years ago by Peter Baumgartner

Yes, sorry.

help_text was being auto-escaped. This trivial patch prevents it from being escaped.

Note: See TracTickets for help on using tickets.
Back to Top