Opened 11 years ago

Closed 11 years ago

#6068 closed (fixed)

typo error in modeltests docstring

Reported by: bartuer <bartuer@…> Owned by: bartuer
Component: Uncategorized Version: master
Severity: Keywords: tests fixtures user-registered management commands
Cc: bartuer@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


in tests/modeltests, fixture and user_commands are all signed with number 37, this is a typo error.

37.Fixtures. ./fixtures/
37.User-registered management commands ./user_commands/

And all docstring of after number 37 should be changed, they are:
tests/modeltests/user_commands/ should be 38
tests/modeltests/test_client/ should be 39
tests/modeltests/empty/ should be 40
tests/modeltests/select_related/ should be 41
tests/modeltests/serializers/ should be 42

Attachments (3)

6068.diff (2.3 KB) - added by bartuer <bartuer@…> 11 years ago.
sprint-6068.diff (2.2 KB) - added by bartuer 11 years ago.
this is the right diff
6068.patch (2.2 KB) - added by Wang Chun <wangchun@…> 11 years ago.
no preview in trac, rename and try again…

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by bartuer <bartuer@…>

Attachment: 6068.diff added

comment:1 Changed 11 years ago by bartuer <bartuer@…>

Owner: changed from nobody to anonymous
Status: newassigned

after upload my patch, find the patch has nothing! so I paste it here:

Index: tests/modeltests/select_related/
--- tests/modeltests/select_related/ (revision 6782)
+++ tests/modeltests/select_related/ (working copy)
@@ -1,5 +1,5 @@


-40. Tests for select_related()
+41. Tests for select_related()

select_related() follows all relationships and pre-caches any foreign key
values so that complex trees can be fetched in a single query. However, this

Index: tests/modeltests/empty/
--- tests/modeltests/empty/ (revision 6782)
+++ tests/modeltests/empty/ (working copy)
@@ -1,5 +1,5 @@


-39. Empty model tests
+40. Empty model tests

These test that things behave sensibly for the rare corner-case of a model with
no fields.

Index: tests/modeltests/serializers/
--- tests/modeltests/serializers/ (revision 6782)
+++ tests/modeltests/serializers/ (working copy)
@@ -1,6 +1,6 @@

# -*- coding: utf-8 -*-

-41. Serialization
+42. Serialization

django.core.serializers provides interfaces to converting Django querysets
to and from "flat" data (i.e. strings).

Index: tests/modeltests/user_commands/
--- tests/modeltests/user_commands/ (revision 6782)
+++ tests/modeltests/user_commands/ (working copy)
@@ -1,5 +1,5 @@


-37. User-registered management commands
+38. User-registered management commands

The utility provides a number of useful commands for managing a
Django project. If you want to add a utility command of your own, you can.

@@ -27,4 +27,4 @@

CommandError: Unknown command: 'explode'

\ No newline at end of file
Index: tests/modeltests/test_client/
--- tests/modeltests/test_client/ (revision 6782)
+++ tests/modeltests/test_client/ (working copy)
@@ -1,6 +1,6 @@

# coding: utf-8

-38. Testing using the Test Client
+39. Testing using the Test Client

The test client is a class that can act like a simple
browser for testing purposes.

comment:2 Changed 11 years ago by bartuer

Owner: changed from anonymous to bartuer
Status: assignednew

comment:3 Changed 11 years ago by bartuer

Status: newassigned

comment:4 Changed 11 years ago by bartuer

Triage Stage: UnreviewedReady for checkin

Changed 11 years ago by bartuer

Attachment: sprint-6068.diff added

this is the right diff

Changed 11 years ago by Wang Chun <wangchun@…>

Attachment: 6068.patch added

no preview in trac, rename and try again...

comment:5 Changed 11 years ago by Malcolm Tredinnick

Resolution: fixed
Status: assignedclosed

(In [6813]) Fixed #6068 -- Updated docstrings in model tests to make the documentation
examples correct. Thanks Wang Chun.

Note: See TracTickets for help on using tickets.
Back to Top