Better saving in newforms-admin ModelAdmin

[Petr Marhoun <petr.marhoun@…>]

There are two very long methods in django.contrib.admin.options.ModelAdmin - save_add and save_change. They do three different things - they save objects, they log what happened and they redirect. So I propose to divide them.

Method add_view would call save_add for saving, log_add for logging and redirect_after_save for redirection. Method change_view would call save_change for saving, log_change for logging and redirect_after_save for redirection.

Methods save_add and save_change would be useful for complex saving which depends on forms and inline formsets together. (It solves #4507.)

Methods log_add and log_change could be used for example for something as AuditModelAdmin or NoLogAdmin.

Method redirect_after_save would be something as render_change_form - technical code common for adding and changing, which is not interesting very much.

I feel that now redirection is quite broken, it does not check permissions correctly. My patch fixes it too.

[Petr Marhoun <petr.marhoun@…>]

new version - after autoescape merge

[Petr Marhoun <petr.marhoun@…>]

new version - after autoescape merge

[Brian Rosner]

This should be solved with the use of ModelForm once it is integrated into ModelAdmin.

[peschler]

Just some little addition: Add a post_url parameter to the proposed redirect_after_save method:

def redirect_after_save(self, request, new_obj, add=False, change=False, post_url="../")

Then use this to redirect when succesfully saved.

Rationale:
Consider a Menu model which contains MenuEntry models. In the admin I want to edit the Menus, MenuEntries should only be accessible through the admin view of the Menu. If a MenuEntry was edited I want to redirect to the Menu it is contained in, rather than to the MenuEntry overview. To achieve this I need to overwrite save_change (in newforms-admin trunk) or redirect_after_save (in the patch version) and duplicate the whole code of these functions. With the additional post_url parameter a simple wrapper would suffice.

[shnur]

Patch cleanly applies to revision 7875

[Brian Rosner]

This actually really isn't critical for a merge. I am going to drop the nfa-blocker and bump to 1.0 beta. I will look at it later.

[Jacob]

#6406 and #8005 were marked as dups; they're not quite the same problem, but the problems there should be solved by a general refactoring of saving. Both have some interesting code, though.

[Jacob]

(In [8265]) Broke the admin's use of LogEntry and user messages out into callbacks on ModelAdmin. Refs #6002.

[Jacob]

(In [8266]) Added ModelAdmin.save_model() and ModelAdmin.save_formset() methods to allow for easier modification of objects/inlines at admin-save time. Refs #6002.

[Jacob]

[8266] should have said "fixed" instead of "refs"; this is done now.

[Jacob]

Milestone 1.0 beta deleted