id summary reporter owner description type status component version severity resolution keywords cc stage has_patch needs_docs needs_tests needs_better_patch easy ui_ux 6002 Better saving in newforms-admin ModelAdmin Petr Marhoun Jacob "There are two very long methods in django.contrib.admin.options.!ModelAdmin - save_add and save_change. They do three different things - they save objects, they log what happened and they redirect. So I propose to divide them. Method add_view would call save_add for saving, log_add for logging and redirect_after_save for redirection. Method change_view would call save_change for saving, log_change for logging and redirect_after_save for redirection. Methods save_add and save_change would be useful for complex saving which depends on forms and inline formsets together. (It solves #4507.) Methods log_add and log_change could be used for example for something as !AuditModelAdmin or !NoLogAdmin. Method redirect_after_save would be something as render_change_form - technical code common for adding and changing, which is not interesting very much. I feel that now redirection is quite broken, it does not check permissions correctly. My patch fixes it too." closed contrib.admin dev fixed Accepted 1 0 0 1 0 0