Inconsistency between Select and SelectMultiple

[Petr Marhoun <petr.marhoun@…>]

From django.newforms.widget.Select:

class Select(Widget):
    def __init__(self, attrs=None, choices=()):
        super(Select, self).__init__(attrs)
        # choices can be any iterable, but we may need to render this widget
        # multiple times. Thus, collapse it into a list so it can be consumed
        # more than once.
        self.choices = list(choices)

And from django.newforms.widget.SelectMultiply:

class SelectMultiple(Widget):
    def __init__(self, attrs=None, choices=()):
        super(SelectMultiple, self).__init__(attrs)
        # choices can be any iterable
        self.choices = choices

Should be choices collapsed? NullBooleanSelect inherits from Select - why doesn't SelectMultiply inherits from Select too?

[Chris Beaven]

Seems fair enough - add some tests to show what this is fixing and it's good to go.

[Petr Marhoun <petr.marhoun@…>]

It was fixed in [7977].