Code

Opened 7 years ago

Closed 3 years ago

#5963 closed (wontfix)

Add render_to_mail to shortcuts package

Reported by: marinho Owned by: nobody
Component: Core (Mail) Version: master
Severity: Keywords: shortcuts
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I read the ticket #1541 and it was closed. But Nick Lane sayd about his function 'render_to_mail', that I think very util to be added to shortcuts package.

I created the patch attached to this ticket for this fix. I did'nt send a test case because I not found where put one.

Attachments (1)

render_to_mail.diff (3.3 KB) - added by marinho 7 years ago.
render_to_mail.diff

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by marinho

render_to_mail.diff

comment:1 Changed 7 years ago by marinho

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Humm.. how that was my first patch, I did an error about 'Has patch" and this reply is to repair it. Sorry.

comment:2 Changed 7 years ago by mtredinnick

  • Resolution set to wontfix
  • Status changed from new to closed

Not worth it. This is a large duplication of all the parameters for send_mail, for a start. We already have the render_to_string() shortcut and you can use that to pass the body text to send_mail(). This shortcut wouldn't shorten any code significantly from what you can already do.

comment:3 Changed 4 years ago by benhodgson

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Personally, I think this would be useful. Worth re–opening? By mtredinnick’s argument, render_to_response shouldn’t exist.

comment:4 Changed 3 years ago by russellm

  • Resolution set to wontfix
  • Status changed from reopened to closed

No, it shouldn't be reopened.

If you disagree with a decision made by a core developer, don't just reopen the ticket; post to Django-developers and make your case. However, put me down as another -1.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.