Opened 16 years ago
Closed 13 years ago
#5963 closed (wontfix)
Add render_to_mail to shortcuts package
| Reported by: | Marinho Brandão | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Mail) | Version: | dev |
| Severity: | Keywords: | shortcuts | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I read the ticket #1541 and it was closed. But Nick Lane sayd about his function 'render_to_mail', that I think very util to be added to shortcuts package.
I created the patch attached to this ticket for this fix. I did'nt send a test case because I not found where put one.
Attachments (1)
Change History (5)
by , 16 years ago
| Attachment: | render_to_mail.diff added |
|---|
comment:1 by , 16 years ago
| Has patch: | set |
|---|
Humm.. how that was my first patch, I did an error about 'Has patch" and this reply is to repair it. Sorry.
comment:2 by , 16 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Not worth it. This is a large duplication of all the parameters for send_mail, for a start. We already have the render_to_string() shortcut and you can use that to pass the body text to send_mail(). This shortcut wouldn't shorten any code significantly from what you can already do.
comment:3 by , 13 years ago
| Resolution: | wontfix |
|---|---|
| Status: | closed → reopened |
Personally, I think this would be useful. Worth re–opening? By mtredinnick’s argument, render_to_response shouldn’t exist.
comment:4 by , 13 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | reopened → closed |
No, it shouldn't be reopened.
If you disagree with a decision made by a core developer, don't just reopen the ticket; post to Django-developers and make your case. However, put me down as another -1.
render_to_mail.diff