Opened 12 years ago

Closed 9 years ago

#5963 closed (wontfix)

Add render_to_mail to shortcuts package

Reported by: Marinho Brandão Owned by: nobody
Component: Core (Mail) Version: master
Severity: Keywords: shortcuts
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


I read the ticket #1541 and it was closed. But Nick Lane sayd about his function 'render_to_mail', that I think very util to be added to shortcuts package.

I created the patch attached to this ticket for this fix. I did'nt send a test case because I not found where put one.

Attachments (1)

render_to_mail.diff (3.3 KB) - added by Marinho Brandão 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by Marinho Brandão

Attachment: render_to_mail.diff added


comment:1 Changed 12 years ago by Marinho Brandão

Has patch: set

Humm.. how that was my first patch, I did an error about 'Has patch" and this reply is to repair it. Sorry.

comment:2 Changed 12 years ago by Malcolm Tredinnick

Resolution: wontfix
Status: newclosed

Not worth it. This is a large duplication of all the parameters for send_mail, for a start. We already have the render_to_string() shortcut and you can use that to pass the body text to send_mail(). This shortcut wouldn't shorten any code significantly from what you can already do.

comment:3 Changed 9 years ago by benhodgson

Resolution: wontfix
Status: closedreopened

Personally, I think this would be useful. Worth re–opening? By mtredinnick’s argument, render_to_response shouldn’t exist.

comment:4 Changed 9 years ago by Russell Keith-Magee

Resolution: wontfix
Status: reopenedclosed

No, it shouldn't be reopened.

If you disagree with a decision made by a core developer, don't just reopen the ticket; post to Django-developers and make your case. However, put me down as another -1.

Note: See TracTickets for help on using tickets.
Back to Top