Opened 9 years ago

Closed 5 years ago

Last modified 5 years ago

#5964 closed New feature (fixed)

utils: urlunquote

Reported by: Thomas Güttler (Home) < > Owned by: Aymeric Augustin
Component: Core (Other) Version: master
Severity: Normal Keywords:
Cc: hv@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Hi,

Using only urllib.unquote() for the result of django.utils.http.urlquote() does
not work. That's why I think an urlunquote() would be good.

A patch inclusive unittest is attached.

Attachments (2)

urlunquote.diff (1.4 KB) - added by Thomas Güttler (Home) < > 9 years ago.
5964.diff (2.8 KB) - added by Simon Meers 5 years ago.

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by Thomas Güttler (Home) < >

Attachment: urlunquote.diff added

comment:1 Changed 9 years ago by Simon G <dev@…>

Triage Stage: UnreviewedDesign decision needed

comment:2 Changed 8 years ago by Adrian Holovaty

Component: ToolsCore framework

comment:3 Changed 6 years ago by Gabriel Hurley

Severity: Normal
Type: New feature

comment:4 Changed 5 years ago by Alex Gaynor

Easy pickings: unset
Triage Stage: Design decision neededAccepted
UI/UX: unset

comment:5 Changed 5 years ago by Simon Meers

Makes sense to me, though we ought to provide unquote_plus since we provide quote_plus. I'll attach patch that covers both, though someone with deep unicode knowledge should double-check whether we should be using encode/decode instead, and whether utf-8 will suffice here.

Changed 5 years ago by Simon Meers

Attachment: 5964.diff added

comment:6 Changed 5 years ago by Aymeric Augustin

Owner: changed from nobody to Aymeric Augustin

comment:7 Changed 5 years ago by Aymeric Augustin

Resolution: fixed
Status: newclosed

In [17407]:

Fixed #5964 -- Added unicode-aware versions of urlunquote and urlunquote_plus.

comment:8 Changed 5 years ago by Thomas Güttler

thank you.

comment:9 Changed 5 years ago by Aymeric Augustin

Well, sorry for the delay...

Note: See TracTickets for help on using tickets.
Back to Top