Opened 8 years ago

Closed 5 years ago

Last modified 4 years ago

#5672 closed (fixed)

i18n minor problem (comma list items separator can't be translated) in django.utils.text.get_text_list()

Reported by: remohammadi Owned by: nobody
Component: Internationalization Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The string ', ' is not translatable in the source code. (django/utils/text.py:142)

In some countries arabic comma (،) is used:
Unicode 0600 block, Arabic comma is 060C.

Attachments (2)

list_separator_translatable.diff (1.1 KB) - added by claudep 5 years ago.
Make list separator translatable
list_separator_translatable-2.diff (3.0 KB) - added by claudep 5 years ago.
Patch including tests

Download all attachments as: .zip

Change History (14)

comment:1 Changed 8 years ago by Simon G <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 6 years ago by garcia_marc

  • Keywords i18n-nofix added

comment:3 Changed 6 years ago by ramiro

  • Summary changed from i18n minor problem in django.utils.text.get_text_list() to i18n minor problem (comma list items separator can't be translated) in django.utils.text.get_text_list()

comment:4 Changed 5 years ago by Alex

  • Triage Stage changed from Design decision needed to Accepted

Changed 5 years ago by claudep

Make list separator translatable

comment:5 Changed 5 years ago by claudep

  • Has patch set
  • Keywords i18n-nofix removed

comment:6 Changed 5 years ago by jezdez

  • milestone set to 1.3
  • Needs tests set

Changed 5 years ago by claudep

Patch including tests

comment:7 Changed 5 years ago by claudep

I added a test, but as I don't speak arabic, it probably doesn't make much sense for a native speaker. However, it should be technically correct.

comment:8 Changed 5 years ago by jezdez

  • Triage Stage changed from Accepted to Ready for checkin

comment:9 Changed 5 years ago by jezdez

  • Needs tests unset

comment:10 Changed 5 years ago by Alex

Fixed in [14876].

comment:11 Changed 5 years ago by Alex

  • Resolution set to fixed
  • Status changed from new to closed

comment:12 Changed 4 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top