Opened 9 years ago

Closed 6 years ago

Last modified 5 years ago

#5672 closed (fixed)

i18n minor problem (comma list items separator can't be translated) in django.utils.text.get_text_list()

Reported by: Reza Mohammadi Owned by: nobody
Component: Internationalization Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The string ', ' is not translatable in the source code. (django/utils/text.py:142)

In some countries arabic comma (،) is used:
Unicode 0600 block, Arabic comma is 060C.

Attachments (2)

list_separator_translatable.diff (1.1 KB) - added by Claude Paroz 6 years ago.
Make list separator translatable
list_separator_translatable-2.diff (3.0 KB) - added by Claude Paroz 6 years ago.
Patch including tests

Download all attachments as: .zip

Change History (14)

comment:1 Changed 9 years ago by Simon G <dev@…>

Triage Stage: UnreviewedDesign decision needed

comment:2 Changed 7 years ago by Marc Garcia

Keywords: i18n-nofix added

comment:3 Changed 7 years ago by Ramiro Morales

Summary: i18n minor problem in django.utils.text.get_text_list()i18n minor problem (comma list items separator can't be translated) in django.utils.text.get_text_list()

comment:4 Changed 6 years ago by Alex Gaynor

Triage Stage: Design decision neededAccepted

Changed 6 years ago by Claude Paroz

Make list separator translatable

comment:5 Changed 6 years ago by Claude Paroz

Has patch: set
Keywords: i18n-nofix removed

comment:6 Changed 6 years ago by Jannis Leidel

milestone: 1.3
Needs tests: set

Changed 6 years ago by Claude Paroz

Patch including tests

comment:7 Changed 6 years ago by Claude Paroz

I added a test, but as I don't speak arabic, it probably doesn't make much sense for a native speaker. However, it should be technically correct.

comment:8 Changed 6 years ago by Jannis Leidel

Triage Stage: AcceptedReady for checkin

comment:9 Changed 6 years ago by Jannis Leidel

Needs tests: unset

comment:10 Changed 6 years ago by Alex Gaynor

Fixed in [14876].

comment:11 Changed 6 years ago by Alex Gaynor

Resolution: fixed
Status: newclosed

comment:12 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top