Ticket #5672: list_separator_translatable-2.diff

django/conf/locale/ar/LC_MESSAGES/django.po

@@ -5022 +5022 @@
 msgid "or"
 msgstr "أو"
 
+#. Translators: This string is used as a separator between list elements
+#: utils/text.py:153
+msgid ", "
+msgstr "، "
+
 #: utils/timesince.py:21
 msgid "year"
 msgid_plural "years"

django/utils/text.py

@@ -1 +1 @@
 import re
 from django.utils.encoding import force_unicode
 from django.utils.functional import allow_lazy
-from django.utils.translation import ugettext_lazy
+from django.utils.translation import ugettext_lazy, ugettext as _
 from htmlentitydefs import name2codepoint
 
 # Capitalizes the first letter of a string.
@@ -148 +148 @@
     """
     if len(list_) == 0: return u''
     if len(list_) == 1: return force_unicode(list_[0])
-    return u'%s %s %s' % (', '.join([force_unicode(i) for i in list_][:-1]), force_unicode(last_word), force_unicode(list_[-1]))
+    return u'%s %s %s' % (
+        # Translators: This string is used as a separator between list elements
+        _(', ').join([force_unicode(i) for i in list_][:-1]),
+        force_unicode(last_word),
+        force_unicode(list_[-1]))
 get_text_list = allow_lazy(get_text_list, unicode)
 
 def normalize_newlines(text):

tests/regressiontests/text/tests.py

@@ -4 +4 @@
 from django.utils.text import *
 from django.utils.http import urlquote, urlquote_plus, cookie_date, http_date
 from django.utils.encoding import iri_to_uri
+from django.utils.translation import activate, deactivate
 
 class TextTests(TestCase):
     """
     Tests for stuff in django.utils.text and other text munging util functions.
     """
 
+    def test_get_text_list(self):
+        self.assertEqual(get_text_list(['a', 'b', 'c', 'd']), u'a, b, c or d')
+        self.assertEqual(get_text_list(['a', 'b', 'c'], 'and'), u'a, b and c')
+        self.assertEqual(get_text_list(['a', 'b'], 'and'), u'a and b')
+        self.assertEqual(get_text_list(['a']), u'a')
+        self.assertEqual(get_text_list([]), u'')
+        activate('ar')
+        self.assertEqual(get_text_list(['a', 'b', 'c']), u"a، b أو c")
+        deactivate()
+
     def test_smart_split(self):
 
         self.assertEquals(list(smart_split(r'''This is "a person" test.''')),