Code

Opened 7 years ago

Closed 7 years ago

#5095 closed (fixed)

newforms doesn't import settings safely enough

Reported by: SmileyChris Owned by: adrian
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

django.conf raises an EnvironmentError if things aren't right. newforms.fields just tries to catch ImportError

Attachments (1)

newforms_settings.patch​ (517 bytes) - added by SmileyChris 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by SmileyChris

comment:1 Changed 7 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [5861]) Fixed #5095 -- newforms now checks for EnvironmentError when importing settings. Thanks, SmileyChris

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.