Opened 9 years ago

Closed 9 years ago

#5095 closed (fixed)

newforms doesn't import settings safely enough

Reported by: Chris Beaven Owned by: Adrian Holovaty
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

django.conf raises an EnvironmentError if things aren't right. newforms.fields just tries to catch ImportError

Attachments (1)

newforms_settings.patch (517 bytes) - added by Chris Beaven 9 years ago.

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by Chris Beaven

Attachment: newforms_settings.patch added

comment:1 Changed 9 years ago by Chris Beaven

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 9 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [5861]) Fixed #5095 -- newforms now checks for EnvironmentError when importing settings. Thanks, SmileyChris

Note: See TracTickets for help on using tickets.
Back to Top