Opened 8 years ago

Closed 8 years ago

#5095 closed (fixed)

newforms doesn't import settings safely enough

Reported by: SmileyChris Owned by: adrian
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

django.conf raises an EnvironmentError if things aren't right. newforms.fields just tries to catch ImportError

Attachments (1)

newforms_settings.patch (517 bytes) - added by SmileyChris 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by SmileyChris

comment:1 Changed 8 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 8 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [5861]) Fixed #5095 -- newforms now checks for EnvironmentError when importing settings. Thanks, SmileyChris

Note: See TracTickets for help on using tickets.
Back to Top