#5096 closed (fixed)
Doc: Model ref mentions sql-based initial data, should use fixtures
| Reported by: | Owned by: | Jacob | |
|---|---|---|---|
| Component: | Documentation | Version: | master |
| Severity: | Keywords: | sprint-pycon08 | |
| Cc: | ctrochalakis | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In 0.96 release notes, there is a mention that fixtures should be used for initial data and custom sql for view, procedures, etc. However the model reference docs show an example using custom sql files and don't mention fixtures at all. For consistency the models ref should describe fixtures and distinguish between the use of fixtures & custom sql files.
Attachments (1)
Change History (23)
comment:1 Changed 11 years ago by
| Owner: | changed from nobody to anonymous |
|---|---|
| Status: | new → assigned |
comment:2 Changed 11 years ago by
| Needs documentation: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
Please don't do anonymous triage.
comment:3 Changed 11 years ago by
| Keywords: | sprint-pycon08 added |
|---|---|
| Owner: | changed from anonymous to Remco Wendt |
| Status: | assigned → new |
comment:4 Changed 11 years ago by
| Status: | new → assigned |
|---|
comment:5 Changed 11 years ago by
Information about fixtures is dispersed between different parts of the documentation, I'm actually thinking of giving the concept of fixtures its own entry in the references list. Going to talk this over with Adrian.
comment:7 Changed 11 years ago by
| Has patch: | set |
|---|
Ok first concept of the fixtures documentation is ready, adding patch.
Changed 11 years ago by
| Attachment: | fixtures-documentation.diff added |
|---|
First concept of fixtures documentation
comment:8 Changed 11 years ago by
| Cc: | ctrochalakis added |
|---|
comment:9 Changed 11 years ago by
| Owner: | changed from Remco Wendt to Jacob |
|---|---|
| Status: | assigned → new |
comment:10 Changed 11 years ago by
| Triage Stage: | Accepted → Ready for checkin |
|---|
Looks nice - I'll proofread and check in.
comment:11 Changed 11 years ago by
| Needs documentation: | unset |
|---|
comment:12 Changed 11 years ago by
| milestone: | → 1.0 |
|---|
comment:13 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
It looks to me like these changes have been incorporated (or added independently) into the new docs. If there is something missing, please provide an updated diff against the new docs.
comment:14 Changed 10 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Sorry, I'm actually still working on this one.
comment:15 Changed 10 years ago by
| Status: | reopened → new |
|---|---|
| Triage Stage: | Ready for checkin → Accepted |
comment:16 Changed 10 years ago by
| Status: | new → assigned |
|---|
comment:17 Changed 10 years ago by
| milestone: | 1.0 → post-1.0 |
|---|
I'm nearly done with this, but I'm not going to have it done for the official 1.0 release. Sorry!
comment:19 Changed 10 years ago by
| milestone: | → 1.1 |
|---|
comment:20 Changed 10 years ago by
Jacob, do you have a partial rewrite of this in a local branch, or should I just take this patch and munge it appropriately? I don't want to duplicate work if you're partially there.
comment:21 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
The docs/howto/initial-data.txt file appears to contain a fairly clear discussion of the two options here. Closing this, since it looks fairly complete. If somebody wants to do something else, open a new ticket with a clear patch against trunk that we can evaluate, but I think the proposed changes have all been merged in now.
Agree.