Opened 17 years ago
Closed 17 years ago
#4511 closed (wontfix)
Missing useful ID attribute in <p>, <li> and <tr> of auto generated form from as_p, as_ul and as_table.
Reported by: | Owned by: | Adrian Holovaty | |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Keywords: | as_p, as_ul, as_table, id | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Design a form built with Form.as_p(), Form.as_ul() or Form.as_table() is dificult becouse there is no ID in <li>,<p> or <tr> tags.
For example: The <input> field "name" need to be larger than the others. I can do that with <input> tag becouse it have an id="id_name", but if I need to do some changes on the entire block containing the "name" field, it´s impossible.
Current form generation:
<li><label for="id_name">Name:</label><input id="id_name"/></li>
Proposed way:
<li id="name"><label for="id_name">Name:</label><input id="id_name"/></li>
This ID attribute is very useful when doing form design, please considere it.
I change the forms.py file from newforms package to act as proposed, and it´s included in this ticket as a patch.
Attachments (2)
Change History (4)
by , 17 years ago
comment:1 by , 17 years ago
The as_*
methods aren't intended to cover every conceivable need of form layout -- they're provided as useful conveniences when you just need a simple/default form layout and don't feel like writing the HTML for it. If you need more customized presentation of the form, don't use the as_*
methods, and instead build the HTML yourself, dropping in fields from the form as needed.
comment:2 by , 17 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
I concur with ubernostrum, this is probably outside of what is needed for most people.
Gustavo: in the future, if you could provide a diff rather than just a copy of the whole file, it would be appreciated!
newforms/forms.py changed to have ID attribute in <p>, <ul> and <tr>