Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4512 closed (invalid)

<ul class="errorlist"> must be inside <p> on forms generated by as_p()

Reported by: gustavo@… Owned by: Adrian Holovaty
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


This way will be easy to keep the error next to the field, in complex form desings. Example: two columns, with fields side by side.

Change History (3)

comment:1 Changed 12 years ago by Matt McClanahan <cardinal@…>

I was going to say that doing this would result in invalid HTML (Paragraphs cannot contain other block-level elements), but apparently as_p() already puts the error list <ul> within a <p>. So instead, I'll say that it would result in even more invalid HTML.

comment:2 Changed 12 years ago by Chris Beaven

Resolution: invalid
Status: newclosed

Invalid, for the reasons Matt said. Just because it's already wrong doesn't mean we should introduce more wrongness. :)

comment:3 Changed 12 years ago by Chris Beaven

See #4527

Note: See TracTickets for help on using tickets.
Back to Top