Code

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4512 closed (invalid)

<ul class="errorlist"> must be inside <p> on forms generated by as_p()

Reported by: gustavo@… Owned by: adrian
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This way will be easy to keep the error next to the field, in complex form desings. Example: two columns, with fields side by side.

Attachments (0)

Change History (3)

comment:1 Changed 7 years ago by Matt McClanahan <cardinal@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I was going to say that doing this would result in invalid HTML (Paragraphs cannot contain other block-level elements), but apparently as_p() already puts the error list <ul> within a <p>. So instead, I'll say that it would result in even more invalid HTML.

comment:2 Changed 7 years ago by SmileyChris

  • Resolution set to invalid
  • Status changed from new to closed

Invalid, for the reasons Matt said. Just because it's already wrong doesn't mean we should introduce more wrongness. :)

comment:3 Changed 7 years ago by SmileyChris

See #4527

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.