Opened 8 years ago

Closed 8 years ago

#4337 closed (fixed)

QueryDict's pop method should accept a default value

Reported by: Gary Wilson <gary.wilson@…> Owned by: adrian
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description


Attachments (2)

4337.diff (892 bytes) - added by Gary Wilson <gary.wilson@…> 8 years ago.
4337.2.diff (883 bytes) - added by Gary Wilson <gary.wilson@…> 8 years ago.
or to be more like the standard library

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Gary Wilson <gary.wilson@…>

Changed 8 years ago by Gary Wilson <gary.wilson@…>

or to be more like the standard library

comment:1 Changed 8 years ago by Gary Wilson <gary.wilson@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 8 years ago by mtredinnick

I've never completely understood the reasons for pop() taking *args in UserDict in the standard library, but I agree that keeping it the same is consistent.

comment:3 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5289]) Fixed #4337 -- Added pop() method to QueryDict. Thanks, Gary Wilson.

Note: See TracTickets for help on using tickets.
Back to Top