Code

Opened 7 years ago

Closed 7 years ago

#4338 closed (fixed)

SessionWrapper should have pop method

Reported by: Gary Wilson <gary.wilson@…> Owned by: adrian
Component: Contrib apps Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description


Attachments (2)

4338.diff (468 bytes) - added by Gary Wilson <gary.wilson@…> 7 years ago.
added pop method to SessionWrapper
4338.2.diff (1.0 KB) - added by Gary Wilson <gary.wilson@…> 7 years ago.
added tests

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Gary Wilson <gary.wilson@…>

added pop method to SessionWrapper

comment:1 Changed 7 years ago by Gary Wilson <gary.wilson@…>

  • Needs documentation unset
  • Needs tests set
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 7 years ago by Gary Wilson <gary.wilson@…>

Waiting on feedback on how we should do tests for contrib apps.

Changed 7 years ago by Gary Wilson <gary.wilson@…>

added tests

comment:3 Changed 7 years ago by Gary Wilson <gary.wilson@…>

  • Needs tests unset
  • Triage Stage changed from Accepted to Ready for checkin

comment:4 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5306]) Fixed #4338 -- Added pop() method to SessionWrapper. Thanks, Gary Wilson.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.