Opened 9 years ago

Closed 9 years ago

#4338 closed (fixed)

SessionWrapper should have pop method

Reported by: Gary Wilson <gary.wilson@…> Owned by: Adrian Holovaty
Component: Contrib apps Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description


Attachments (2)

4338.diff (468 bytes) - added by Gary Wilson <gary.wilson@…> 9 years ago.
added pop method to SessionWrapper
4338.2.diff (1.0 KB) - added by Gary Wilson <gary.wilson@…> 9 years ago.
added tests

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by Gary Wilson <gary.wilson@…>

Attachment: 4338.diff added

added pop method to SessionWrapper

comment:1 Changed 9 years ago by Gary Wilson <gary.wilson@…>

Needs documentation: unset
Needs tests: set
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 9 years ago by Gary Wilson <gary.wilson@…>

Waiting on feedback on how we should do tests for contrib apps.

Changed 9 years ago by Gary Wilson <gary.wilson@…>

Attachment: 4338.2.diff added

added tests

comment:3 Changed 9 years ago by Gary Wilson <gary.wilson@…>

Needs tests: unset
Triage Stage: AcceptedReady for checkin

comment:4 Changed 9 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [5306]) Fixed #4338 -- Added pop() method to SessionWrapper. Thanks, Gary Wilson.

Note: See TracTickets for help on using tickets.
Back to Top