Opened 18 years ago
Closed 18 years ago
#4152 closed (fixed)
[unicode] Unicode-aware translation
Reported by: | Owned by: | Malcolm Tredinnick | |
---|---|---|---|
Component: | Uncategorized | Version: | other branch |
Severity: | Keywords: | unicode | |
Cc: | Maniac@…, mir@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Attachments (3)
Change History (9)
comment:1 by , 18 years ago
Cc: | added |
---|
comment:2 by , 18 years ago
Summary: | [unicode] Unicode-aware translation → [unicode][patch] Unicode-aware translation |
---|
comment:3 by , 18 years ago
Cc: | added |
---|
follow-up: 5 comment:4 by , 18 years ago
Cc: | removed |
---|---|
Has patch: | set |
Owner: | changed from | to
Summary: | [unicode][patch] Unicode-aware translation → [unicode] Unicode-aware translation |
Triage Stage: | Unreviewed → Accepted |
Ivan,
- Not sure why you aren't seeing errors in make-messages.py. I get them all the time with both gettext 0.14.5 and gettext 0.16.1. Most odd. It's documented as not valid for gettext msg ids anyway.
- There's no problem with using u".." strings inside the gettext() calls providing they use ASCII characters. xgettext only looks for the quotes anyway. I haven't been bothering to change them in localflavor/ contributions.
- Old forms is deprecated, not absent. We need to fix oldforms, too, for backwards compatibility. I don't know if oldforms will still be present in 1.0 or not (I would guess, yes, but
import forms
will import newforms by default). We can't break the tree once unicode is merged with trunk and there's a lot of code still using oldforms. I'll fix that up, though, it's not too hard, I suspect.
Patch looks good from just reading it through once. I'll merge it tonight. Thanks.
(Oh, and stop putting [patch]
in the title. There's a checkbox for that. Using "[patch]" makes it look like you're still living in 2006.)
comment:5 by , 18 years ago
- Not sure why you aren't seeing errors in make-messages.py. I get them all the time with both gettext 0.14.5 and gettext 0.16.1. Most odd. It's documented as not valid for gettext msg ids anyway.
Yes, I just noted this as a strange fact, not for using it :-)
- There's no problem with using u".." strings inside the gettext() calls providing they use ASCII characters. xgettext only looks for the quotes anyway. I haven't been bothering to change them in localflavor/ contributions.
I thought that this may be misleading for people reading source and thinking "if it can accept unicode I could use my native language as a base for translation".
- Old forms is deprecated, not absent. We need to fix oldforms, too, for backwards compatibility. I don't know if oldforms will still be present in 1.0 or not (I would guess, yes, but
import forms
will import newforms by default). We can't break the tree once unicode is merged with trunk and there's a lot of code still using oldforms. I'll fix that up, though, it's not too hard, I suspect.
I actually have core.validators converted locally, I'll just update the patch in a few hours.
(Oh, and stop putting
[patch]
in the title. There's a checkbox for that. Using "[patch]" makes it look like you're still living in 2006.)
Ouch :-). Perhaps I was trying too hard to get used to it and now it strikes back :-).
by , 18 years ago
Attachment: | 4152.2.cumulative.diff added |
---|
Cumulative patch including oldforms and core.validators
comment:6 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
I've made two flavors of a patch. First one only fixes template tags for translations (and is very small). Another includes the first one plus replaces [n]gettext* -> u[n]gettext in db fields, newforms fields. Things to think of: