Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#3957 closed (fixed)

BRCPFField LocalflavorBR

Reported by: danielvaz@… Owned by: Adrian Holovaty
Component: contrib.localflavor Version: dev
Severity: Keywords: brcpffield, localflavor, br
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

A new implementation of BRCPFField was made with the code style of BRCNPJField, but the fields NOT like same.

Attachments (1)

tests_br_cpffield.diff​ (2.0 KB ) - added by danielvaz@… 18 years ago.

Download all attachments as: .zip

Change History (14)

by danielvaz@…, 18 years ago

Attachment: tests_br_cpffield.diff​ added

comment:1 by danielvaz@…, 18 years ago

I try send the patch (I already send the tests) but this is marked as spam. How to solve this?

comment:2 by Adrian Holovaty, 18 years ago

Component: Contrib apps → django.contrib.localflavor

comment:3 by danielvaz@…, 18 years ago

Internal Error
Submission rejected as potential spam (Akismet says content is spam)

How to solve it? How do I can send the BRCPFField?

The tests of BRCPFField has been send.

comment:4 by Simon G. <dev@…>, 18 years ago

Triage Stage: Unreviewed → Accepted

Sorry, everyone's having a few issues with ​Trac choking on binaries coming through the spam filter. Can you try to attach it again, and if that doesn't work, paste it onto dpaste.com (remember to check "hold"!) and put a link in.

Thanks :)

comment:5 by danielvaz@…, 18 years ago

I try once more, but it's dont work. So i post in dpaste.com as recomended.

​http://dpaste.com/hold/8364/

I'm waiting for answers now.

Thanks

comment:6 by Simon G. <dev@…>, 18 years ago

Has patch: set
Triage Stage: Accepted → Ready for checkin

comment:7 by Malcolm Tredinnick, 18 years ago

Patch needs improvement: set
Triage Stage: Ready for checkin → Accepted

This class needs at least some documentation to explain what it does. The fields in localflavor should at least be vaguely understandable to people outside that locale and doing a Google search for BRCPF doesn't turn up anything relevant in the first few hits. Please put a small docstring at the top of the class explaining what the field is used for (perhaps with a reference to an English-language web page explaining what it is -- e.g. wikipedia -- if possible).

Also, you cannot use unicode strings inside gettext() reliably -- this is a constraint in Python not in Django (although Django will soon add ugettext() support). They will break if they contain non-ASCII characaters. So best to remove the u"..." markers and just use normal strings there.

comment:8 by danielvaz@…, 18 years ago

Doc String added.
References from wikipedia added.
u"strings" removed.

​http://dpaste.com/hold/8833/

I'm waiting for your answer, mtredinnick.
Thank you.

comment:9 by danielvaz@…, 18 years ago

This patch will be apply at SVN version?

comment:10 by Simon G. <dev@…>, 18 years ago

Triage Stage: Accepted → Ready for checkin

comment:11 by Malcolm Tredinnick, 18 years ago

Resolution: → fixed
Status: new → closed

(In [5089]) Fixed #3957, #3945 -- Added CPF and CNPJ (some Brazilian identity numbers)
fields to the Brazilian localflavor. Thanks, onaiort@… and
danielvaz@….

in reply to:  11 comment:12 by danielvaz@…, 18 years ago

You forgot tests_br_cpffield.diff (tests/regressiontests/forms/localflavor.py).
Do I can reopen the ticket or no?
I'm waiting your answer.

Thanks - Daniel Alves Barbosa de Oliveira Vaz

comment:13 by Malcolm Tredinnick, 18 years ago

(In [5108]) Added tests for Brazilian CRPF field that were accidentally omitted in [5089].
Refs #3957.

Note: See TracTickets for help on using tickets.
Back to Top