Code

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#3957 closed (fixed)

BRCPFField LocalflavorBR

Reported by: danielvaz@… Owned by: adrian
Component: contrib.localflavor Version: master
Severity: Keywords: brcpffield, localflavor, br
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

A new implementation of BRCPFField was made with the code style of BRCNPJField, but the fields NOT like same.

Attachments (1)

tests_br_cpffield.diff (2.0 KB) - added by danielvaz@… 7 years ago.

Download all attachments as: .zip

Change History (14)

Changed 7 years ago by danielvaz@…

comment:1 Changed 7 years ago by danielvaz@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I try send the patch (I already send the tests) but this is marked as spam. How to solve this?

comment:2 Changed 7 years ago by adrian

  • Component changed from Contrib apps to django.contrib.localflavor

comment:3 Changed 7 years ago by danielvaz@…

Internal Error
Submission rejected as potential spam (Akismet says content is spam)

How to solve it? How do I can send the BRCPFField?

The tests of BRCPFField has been send.

comment:4 Changed 7 years ago by Simon G. <dev@…>

  • Triage Stage changed from Unreviewed to Accepted

Sorry, everyone's having a few issues with Trac choking on binaries coming through the spam filter. Can you try to attach it again, and if that doesn't work, paste it onto dpaste.com (remember to check "hold"!) and put a link in.

Thanks :)

comment:5 Changed 7 years ago by danielvaz@…

I try once more, but it's dont work. So i post in dpaste.com as recomended.

http://dpaste.com/hold/8364/

I'm waiting for answers now.

Thanks

comment:6 Changed 7 years ago by Simon G. <dev@…>

  • Has patch set
  • Triage Stage changed from Accepted to Ready for checkin

comment:7 Changed 7 years ago by mtredinnick

  • Patch needs improvement set
  • Triage Stage changed from Ready for checkin to Accepted

This class needs at least some documentation to explain what it does. The fields in localflavor should at least be vaguely understandable to people outside that locale and doing a Google search for BRCPF doesn't turn up anything relevant in the first few hits. Please put a small docstring at the top of the class explaining what the field is used for (perhaps with a reference to an English-language web page explaining what it is -- e.g. wikipedia -- if possible).

Also, you cannot use unicode strings inside gettext() reliably -- this is a constraint in Python not in Django (although Django will soon add ugettext() support). They will break if they contain non-ASCII characaters. So best to remove the u"..." markers and just use normal strings there.

comment:8 Changed 7 years ago by danielvaz@…

Doc String added.
References from wikipedia added.
u"strings" removed.

http://dpaste.com/hold/8833/

I'm waiting for your answer, mtredinnick.
Thank you.

comment:9 Changed 7 years ago by danielvaz@…

This patch will be apply at SVN version?

comment:10 Changed 7 years ago by Simon G. <dev@…>

  • Triage Stage changed from Accepted to Ready for checkin

comment:11 follow-up: Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5089]) Fixed #3957, #3945 -- Added CPF and CNPJ (some Brazilian identity numbers)
fields to the Brazilian localflavor. Thanks, onaiort@… and
danielvaz@….

comment:12 in reply to: ↑ 11 Changed 7 years ago by danielvaz@…

You forgot tests_br_cpffield.diff (tests/regressiontests/forms/localflavor.py).
Do I can reopen the ticket or no?
I'm waiting your answer.

Thanks - Daniel Alves Barbosa de Oliveira Vaz

comment:13 Changed 7 years ago by mtredinnick

(In [5108]) Added tests for Brazilian CRPF field that were accidentally omitted in [5089].
Refs #3957.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.