Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3945 closed (fixed)

BR localflavor update

Reported by: onaiort@… Owned by: onaiort@…
Component: contrib.localflavor Version: master
Severity: Keywords:
Cc: onaiort@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: UI/UX:

Description

Support for CNPJ fields in BR localflavor.

Attachments (2)

django_cnpj_localflavor.diff (1.6 KB) - added by onaiort@… 8 years ago.
Initial implementation
django_cnpj_localflavor_take2.diff (3.3 KB) - added by onaiort@… 8 years ago.
minor improvements plus tests as requested

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by onaiort@…

Initial implementation

comment:1 Changed 8 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from adrian to onaiort@…
  • Patch needs improvement unset

comment:2 Changed 8 years ago by Simon G. <dev@…>

  • Needs tests set
  • Triage Stage changed from Unreviewed to Accepted

This looks good, but can you make a test for this with a few dummy values? (if you're stuck - see some of the tests in source:tests/regressiontests/forms/localflavor.py)

Changed 8 years ago by onaiort@…

minor improvements plus tests as requested

comment:3 Changed 8 years ago by adrian

  • Component changed from Contrib apps to django.contrib.localflavor

comment:4 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5089]) Fixed #3957, #3945 -- Added CPF and CNPJ (some Brazilian identity numbers)
fields to the Brazilian localflavor. Thanks, onaiort@… and
danielvaz@….

comment:5 Changed 8 years ago by anonymous

Actually, my name is Henrique Romano. I don't see any field to set it in the trac, sorry.

comment:6 Changed 8 years ago by mtredinnick

(In [5107]) Updated Henrique Romano's AUTHOR entry. Refs #3945.

Note: See TracTickets for help on using tickets.
Back to Top