Opened 18 years ago
Closed 18 years ago
#3958 closed (fixed)
little changes for conformance to ATOM & RSS specs
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | contrib.syndication | Version: | dev |
| Severity: | Keywords: | rss, atom, feedgenerator | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
A patch for the feedgenerator that adds <lastBuildDate> to RSS feeds (similar to the ATOM <updated>) and <subtitle> to ATOM feeds (similar to the RSS <description>).
Attachments (3)
Change History (10)
by , 18 years ago
| Attachment: | feedgenerator.diff added |
|---|
comment:1 by , 18 years ago
| Triage Stage: | Unreviewed → Ready for checkin |
|---|
comment:2 by , 18 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Ready for checkin → Accepted |
Subtitle does not have the same meaning as description. So that part of the patch is not appropriate. We already handle the subtitle element for Atom feeds and it's uses the subtitle attribute on the Feed subclass the client writes.
comment:3 by , 18 years ago
Well, the spec says :
"The "atom:subtitle" element is a Text construct that conveys a human-readable description or subtitle for a feed."
So yes, I think it is the equivalent of <description>.
But anyway, I have just noticed that we could specify the <subtitle> for ATOM feeds - like you said, my mistake -, so I can manage that, but we could do better that two different arguments for a same element...
comment:4 by , 18 years ago
| Patch needs improvement: | unset |
|---|
by , 18 years ago
| Attachment: | feedgenerator.3.diff added |
|---|
And a bonus patch that sets the <subtitle> to the given argument subtitle if it exists or the description if not, since the <subtitle> is almost the description. Nothing is broken, and that allows to use the same code for ATOM & RSS feeds.
comment:5 by , 18 years ago
It is misleading to use the description element for the subtitle. The subtitle could be used as a description, but need not be, hence they are not identical. If somebody wants to use their description as subtitle in their Atom feed then they can write subtitle=description in their class.
We provide access to the subtitle element already. Two ways to do the same thing is confusing and not the Python way.
A documentation patch to clear up that subtitle is available in Atom feeds would be fine, if you like.
So, patch 2 is accepted, patch 3 is not.
comment:6 by , 18 years ago
Yes, you are right, that is smarter to have a required argument "description" not used, instead of putting its content in the <subtitle> of which main usage is to contain the description of the feed. But maybe it is the "Python way" you are talking about... Anyway, I won't write any doc about that, because I think this behaviour is stupid and especially because I am not talking a fluently English.
comment:7 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
the patch