pass value to field specific clean function

[Henrik Vendelbo <info@…>]

newforms has this bit of code in the full_clean function:

            try:
                value = field.clean(value)
                self.clean_data[name] = value
                if hasattr(self, 'clean_%s' % name):
                    value = getattr(self, 'clean_%s' % name)()
                self.clean_data[name] = value
            except ValidationError, e:
                errors[name] = e.messages

Why is value not passed to the clean_%s function? Since it is required to return the accepted value, it is odd that it is forced to look it up. Basicly a dictionary read and assignment is required with no obvious gain. Logically I find it odd as well that clean_data contains values that are not cleaned fully yet.

[James Bennett]

(cleaning up code formatting in description)

[Gary Wilson <gary.wilson@…>]

Seems logical to me. I think it is certainly a bug that clean_data will retain the value even if clean_XXX raises a ValidationError. So even if it is decided that value shouldn't be passed to clean_XXX, we at least need to fix the clean_data problem.

[Gary Wilson <gary.wilson@…>]

Pass the value to clean_XXX method and don't save to clean_data first.

[Gary Wilson <gary.wilson@…>]

Only the passing of value to clean_XXX method, with test fixes.

[Gary Wilson <gary.wilson@…>]

If this change goes in, then also consider removing the line specified in the first patch, which would fix #4391.

[Philippe Raoult]

it's really an implementation detail, but none the less fixed in [5346].