Opened 72 minutes ago
Last modified 62 minutes ago
#37190 assigned Bug
Deprecation warning for action_location parameter should mention subclass and/or point to user code
| Reported by: | Jacob Walls | Owned by: | Mike Edmunds |
|---|---|---|---|
| Component: | contrib.admin | Version: | 6.1 |
| Severity: | Release blocker | Keywords: | |
| Cc: | Mike Edmunds, Marcelo Galigniana | Triage Stage: | Unreviewed |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
As pointed out in #37187, we have deprecation warnings being emitted on wsgiref frames for the deprecation warning added in #12090:
/Library/Frameworks/Python.framework/Versions/3.13/lib/python3.13/wsgiref/handlers.py:137: RemovedInDjango70Warning: Overriding get_action_choices() without the 'action_location' parameter is deprecated. Update the signature to get_action_choices(self, request, default_choices=None, action_location=ActionLocation.CHANGE_LIST).
Analysis from #37187:
... trying to warn about an overridden subclass method that has already been called so is no longer on the stack.
Change History (4)
comment:1 by , 71 minutes ago
| Summary: | Deprecation warning for action_location parameter should warn about external use instead of skipping Django frames → Deprecation warning for action_location parameter should mention subclass and not skip Django frames |
|---|
comment:2 by , 71 minutes ago
| Summary: | Deprecation warning for action_location parameter should mention subclass and not skip Django frames → Deprecation warning for action_location parameter should mention subclass and/or point to user code |
|---|
comment:3 by , 68 minutes ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:4 by , 62 minutes ago
Note:
See TracTickets
for help on using tickets.
The new
warnings.warn_explicit()helper being proposed for #37187 could also cover this.