Code

Opened 5 years ago

Last modified 9 months ago

#12090 assigned New feature

Show admin actions on the edit pages too

Reported by: apollo13 Owned by: jgmize
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: jezdez, carljm, dbrgn, jgmize, apollo13 Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: yes

Description

Currently the workflow for comment moderation might look like this (without knowing the comment moderation admin actions ;)):

  • Look at the overview page
  • If in doubt open the comment in a new page
  • if it's spam go back to the previous page, select it and execute the admin action

We could redisplay the admin actions box in the detail views (where they of course would only effect the current object) to prevent the unneeded roundtrip.

Attachments (1)

Admin Change Action Screenshot.png (63.5 KB) - added by jgmize 16 months ago.
Admin change action screenshot

Download all attachments as: .zip

Change History (20)

comment:1 Changed 5 years ago by jezdez

  • Cc jezdez added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Interesting idea!

One question though: The current admin actions usually return the user to the object list, what would be the behavior after running the action from the object detail page?

comment:2 Changed 5 years ago by carljm

  • Cc carljm added

comment:3 Changed 5 years ago by jezdez

  • Owner changed from nobody to jezdez
  • Status changed from new to assigned

comment:5 Changed 4 years ago by russellm

  • Triage Stage changed from Unreviewed to Design decision needed

comment:6 Changed 4 years ago by jezdez

  • Triage Stage changed from Design decision needed to Accepted

comment:7 Changed 4 years ago by scaphilo

Is it possible to give a short input on this ticket? I'd prefer to have a button like "save", "save and add", "save and edit" istead of a drop down list to select the button. Perhaps it possible to make that selectable.
What do you think about that?

comment:8 Changed 4 years ago by hamlet

Regarding the design issue let me propose to allow for a list of actions that are offered as individual buttons on the change page next to 'Save', 'Save and add another': 'Save and /action/', e.g. via:

class ArticleAdmin(admin.ModelAdmin):
    list_display = ['title', 'status']
    actions = [publish, unpublish, comments_close]
    save_plus_action = [unpublish, comments_close]
    save_plus_action_done = [publish]

As it's unclear whether the list or change page should display after that, we would need the secondary option, say save_plus_action_done to leave the change page after saving and firing this action.

comment:9 Changed 4 years ago by jezdez

  • Owner jezdez deleted
  • Status changed from assigned to new

comment:10 Changed 3 years ago by julien

  • Severity set to Normal
  • Type set to New feature

comment:11 Changed 3 years ago by julien

  • UI/UX set

comment:12 Changed 2 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:13 Changed 2 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:14 Changed 2 years ago by aaugustin

  • UI/UX set

Revert accidental batch modification.

comment:15 Changed 2 years ago by dbrgn

  • Cc dbrgn added

This would be a very nice change. There are some types of changes that shouldn't be done as a batch process, as they might depend on each other, so the order in which they're processed is critical.

Last edited 2 years ago by dbrgn (previous) (diff)

comment:16 Changed 16 months ago by jgmize

  • Owner set to jgmize
  • Status changed from new to assigned

Changed 16 months ago by jgmize

Admin change action screenshot

comment:17 Changed 16 months ago by jgmize

  • Cc jgmize added

comment:18 Changed 16 months ago by apollo13

  • Cc apollo13 added

@jgmize I can't comment about the design but I'd like to propose some changes: It would be nice if one where able to reuse the existing actions, this would mean supporting short_description and short_description_plural and using the correct version depending on the page (+some backwards shim). Also it would be interesting to see how your current stuff looks with save_on_top = True

comment:19 Changed 9 months ago by timo

  • Patch needs improvement set

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as assigned
The owner will be changed from jgmize to anonymous. Next status will be 'assigned'
The ticket will be disowned. Next status will be 'new'
as The resolution will be set. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.