Opened 15 years ago
Last modified 3 days ago
#12090 assigned New feature
Show admin actions on the edit pages too
Description ¶
Currently the workflow for comment moderation might look like this (without knowing the comment moderation admin actions ;)):
- Look at the overview page
- If in doubt open the comment in a new page
- if it's spam go back to the previous page, select it and execute the admin action
We could redisplay the admin actions box in the detail views (where they of course would only effect the current object) to prevent the unneeded roundtrip.
According to the ticket's flags, the next step(s) to move this issue forward are:
- To improve the patch as described in the pull request review comments or on this ticket, then uncheck "Patch needs improvement".
If creating a new pull request, include a link to the pull request in the ticket comment when making that update. The usual format is:
[https://github.com/django/django/pull/#### PR]
.
Change History (38)
comment:1 by , 15 years ago
Cc: | added |
---|
comment:2 by , 15 years ago
Cc: | added |
---|
comment:3 by , 15 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:4 by , 15 years ago
See: http://groups.google.com/group/django-developers/browse_thread/thread/3fee283ae3695352 for the discussion.
comment:5 by , 15 years ago
Triage Stage: | Unreviewed → Design decision needed |
---|
comment:6 by , 15 years ago
Triage Stage: | Design decision needed → Accepted |
---|
comment:7 by , 15 years ago
Is it possible to give a short input on this ticket? I'd prefer to have a button like "save", "save and add", "save and edit" istead of a drop down list to select the button. Perhaps it possible to make that selectable.
What do you think about that?
comment:8 by , 14 years ago
Regarding the design issue let me propose to allow for a list of actions that are offered as individual buttons on the change page next to 'Save', 'Save and add another': 'Save and /action/', e.g. via:
class ArticleAdmin(admin.ModelAdmin): list_display = ['title', 'status'] actions = [publish, unpublish, comments_close] save_plus_action = [unpublish, comments_close] save_plus_action_done = [publish]
As it's unclear whether the list or change page should display after that, we would need the secondary option, say save_plus_action_done
to leave the change page after saving and firing this action.
comment:9 by , 14 years ago
Owner: | removed |
---|---|
Status: | assigned → new |
comment:10 by , 14 years ago
Severity: | → Normal |
---|---|
Type: | → New feature |
comment:11 by , 14 years ago
UI/UX: | set |
---|
comment:15 by , 13 years ago
Cc: | added |
---|
This would be a very nice change. There are some types of changes that shouldn't be done as a batch process, as they might depend on each other, so the order in which they're processed is critical.
comment:16 by , 12 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
submitted pull request: https://github.com/django/django/pull/928
by , 12 years ago
Attachment: | Admin Change Action Screenshot.png added |
---|
Admin change action screenshot
comment:17 by , 12 years ago
Cc: | added |
---|
comment:18 by , 12 years ago
Cc: | added |
---|
@jgmize I can't comment about the design but I'd like to propose some changes: It would be nice if one where able to reuse the existing actions, this would mean supporting short_description
and short_description_plural
and using the correct version depending on the page (+some backwards shim). Also it would be interesting to see how your current stuff looks with save_on_top = True
comment:19 by , 11 years ago
Patch needs improvement: | set |
---|
comment:20 by , 4 years ago
Has patch: | set |
---|
A very old patch, but a start nonetheless in f62d6e44dda5f457d8108fbae005e026b82e138e in the PR linked above.
comment:21 by , 3 years ago
Owner: | removed |
---|---|
Status: | assigned → new |
comment:22 by , 2 years ago
Has patch: | unset |
---|---|
Owner: | set to |
Patch needs improvement: | unset |
Status: | new → assigned |
comment:23 by , 2 years ago
Has patch: | set |
---|
comment:25 by , 2 years ago
Patch needs improvement: | set |
---|
Going to change actions buttons -> dropdown with actions (same as list)
comment:26 by , 2 years ago
I'm leaving a message here to let you know that I'm still active and contributing but I don't have enough time to dedicate to this big ticket yet.
If someone has the time to work in it feel free to claim it! If not -> I'll be working on it later for sure, but I don't know exactly when.
Thank you!
comment:27 by , 20 months ago
Update: I've started to working again! Pull request in draft, with test passing, but there is documentation and other changes to do!
comment:28 by , 20 months ago
Cc: | removed |
---|
comment:29 by , 20 months ago
Patch needs improvement: | unset |
---|---|
UI/UX: | unset |
comment:30 by , 19 months ago
Patch needs improvement: | set |
---|---|
UI/UX: | set |
comment:31 by , 17 months ago
Patch needs improvement: | unset |
---|---|
UI/UX: | unset |
comment:34 by , 10 months ago
Needs documentation: | set |
---|---|
Patch needs improvement: | set |
comment:35 by , 7 months ago
Needs documentation: | unset |
---|---|
Patch needs improvement: | unset |
comment:36 by , 6 months ago
Patch needs improvement: | set |
---|
comment:37 by , 3 days ago
Cc: | added |
---|
Interesting idea!
One question though: The current admin actions usually return the user to the object list, what would be the behavior after running the action from the object detail page?