Opened 14 years ago

Last modified 6 months ago

#12090 assigned New feature

Show admin actions on the edit pages too

Reported by: Florian Apolloner Owned by: Marcelo Galigniana
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Jannis Leidel, Carl Meyer, jgmize, Florian Apolloner Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Currently the workflow for comment moderation might look like this (without knowing the comment moderation admin actions ;)):

  • Look at the overview page
  • If in doubt open the comment in a new page
  • if it's spam go back to the previous page, select it and execute the admin action

We could redisplay the admin actions box in the detail views (where they of course would only effect the current object) to prevent the unneeded roundtrip.

Attachments (1)

Admin Change Action Screenshot.png (63.5 KB ) - added by jgmize 11 years ago.
Admin change action screenshot

Download all attachments as: .zip

Change History (34)

comment:1 by Jannis Leidel, 14 years ago

Cc: Jannis Leidel added

Interesting idea!

One question though: The current admin actions usually return the user to the object list, what would be the behavior after running the action from the object detail page?

comment:2 by Carl Meyer, 14 years ago

Cc: Carl Meyer added

comment:3 by Jannis Leidel, 14 years ago

Owner: changed from nobody to Jannis Leidel
Status: newassigned

comment:5 by Russell Keith-Magee, 14 years ago

Triage Stage: UnreviewedDesign decision needed

comment:6 by Jannis Leidel, 14 years ago

Triage Stage: Design decision neededAccepted

comment:7 by Aaron Riedener, 14 years ago

Is it possible to give a short input on this ticket? I'd prefer to have a button like "save", "save and add", "save and edit" istead of a drop down list to select the button. Perhaps it possible to make that selectable.
What do you think about that?

comment:8 by hamlet, 14 years ago

Regarding the design issue let me propose to allow for a list of actions that are offered as individual buttons on the change page next to 'Save', 'Save and add another': 'Save and /action/', e.g. via:

class ArticleAdmin(admin.ModelAdmin):
    list_display = ['title', 'status']
    actions = [publish, unpublish, comments_close]
    save_plus_action = [unpublish, comments_close]
    save_plus_action_done = [publish]

As it's unclear whether the list or change page should display after that, we would need the secondary option, say save_plus_action_done to leave the change page after saving and firing this action.

comment:9 by Jannis Leidel, 13 years ago

Owner: Jannis Leidel removed
Status: assignednew

comment:10 by Julien Phalip, 13 years ago

Severity: Normal
Type: New feature

comment:11 by Julien Phalip, 13 years ago

UI/UX: set

comment:12 by Aymeric Augustin, 12 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:13 by Aymeric Augustin, 12 years ago

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:14 by Aymeric Augustin, 12 years ago

UI/UX: set

Revert accidental batch modification.

comment:15 by Danilo Bargen, 12 years ago

Cc: Danilo Bargen added

This would be a very nice change. There are some types of changes that shouldn't be done as a batch process, as they might depend on each other, so the order in which they're processed is critical.

Last edited 12 years ago by Danilo Bargen (previous) (diff)

comment:16 by jgmize, 11 years ago

Owner: set to jgmize
Status: newassigned

by jgmize, 11 years ago

Admin change action screenshot

comment:17 by jgmize, 11 years ago

Cc: jgmize added

comment:18 by Florian Apolloner, 11 years ago

Cc: Florian Apolloner added

@jgmize I can't comment about the design but I'd like to propose some changes: It would be nice if one where able to reuse the existing actions, this would mean supporting short_description and short_description_plural and using the correct version depending on the page (+some backwards shim). Also it would be interesting to see how your current stuff looks with save_on_top = True

comment:19 by Tim Graham, 10 years ago

Patch needs improvement: set

comment:20 by Jacob Walls, 3 years ago

Has patch: set

A very old patch, but a start nonetheless in f62d6e44dda5f457d8108fbae005e026b82e138e in the PR linked above.

comment:21 by Mariusz Felisiak, 20 months ago

Owner: jgmize removed
Status: assignednew

comment:22 by Marcelo Galigniana, 19 months ago

Has patch: unset
Owner: set to Marcelo Galigniana
Patch needs improvement: unset
Status: newassigned

comment:23 by Marcelo Galigniana, 19 months ago

Has patch: set

comment:24 by Marcelo Galigniana, 19 months ago

comment:25 by Marcelo Galigniana, 19 months ago

Patch needs improvement: set

Going to change actions buttons -> dropdown with actions (same as list)

comment:26 by Marcelo Galigniana, 13 months ago

I'm leaving a message here to let you know that I'm still active and contributing but I don't have enough time to dedicate to this big ticket yet.

If someone has the time to work in it feel free to claim it! If not -> I'll be working on it later for sure, but I don't know exactly when.

Thank you!

comment:27 by Marcelo Galigniana, 9 months ago

Update: I've started to working again! Pull request in draft, with test passing, but there is documentation and other changes to do!

comment:28 by Danilo Bargen, 9 months ago

Cc: Danilo Bargen removed

comment:29 by Marcelo Galigniana, 8 months ago

Patch needs improvement: unset
UI/UX: unset

comment:30 by Natalia Bidart, 8 months ago

Patch needs improvement: set
UI/UX: set

comment:31 by Marcelo Galigniana, 6 months ago

Patch needs improvement: unset
UI/UX: unset

comment:32 by Marcelo Galigniana, 6 months ago

Patch needs improvement: set

Test failing!

Working on fix.

comment:33 by Marcelo Galigniana, 6 months ago

Patch needs improvement: unset

Tests passing

Note: See TracTickets for help on using tickets.
Back to Top