Missing label on each <select> in a fieldset

[Jacob Walls]

As Thibaud mentioned ​here when use_fieldset was added to forms, we're lacking a label on each <select> element in a <fieldset>, even though a <legend> is present for the fieldset.

Now that the admin uses Widget.use_fieldset since #35892, it's easy to reproduce by just checking a ForeignKey field in the admin:

Then, in Chrome Dev Tools, the lighthouse tab reports:

Select elements do not have associated label elements.

Pure forms reproducer, in a shell:

from django.db import models
from django import forms

class Person(models.Model):
    best_friend = models.ForeignKey(
        "auth.User",
        models.CASCADE,
    )
    class Meta:
        app_label = "myapp.Person"

class MyWidget(forms.Select):
    use_fieldset = True

class PersonForm(forms.ModelForm):
    class Meta:
        model = Person
        fields = ["best_friend"]
        widgets = {"best_friend": MyWidget}

print(PersonForm().as_p())

<p>
    <label for="id_best_friend">Best friend:</label>
    <select name="best_friend" required id="id_best_friend">
  <option value="" selected>---------</option>

  <option value="2">anonymous</option>

  <option value="1">admin</option>

</select>
    
    
      
    
  </p>

---

Tentatively assigning to Eli as a Djangonaut Space navigator to evaluate if a good fit for anyone.

[Jacob Walls]

There's some relevant advice in a related ticket: ticket:36509#comment:1

[Natalia Bidart]

Thank you!

[Bhuvnesh Nama]

Submitted PR for review.

PR: ​https://github.com/django/django/pull/20933

[Bhuvnesh Nama]

I've pushed updates to the pull request to address the review feedback, including adding tests and updating the implementation.

PR: ​https://github.com/django/django/pull/20933

[Jacob Walls]

David's helpful review revealed that it was a bug in 4187da258fe212d494cb578a0bc2b52c4979ab95 that self.use_fieldset = True was done naively on RelatedFieldWidgetWrapper in the admin, so elevating to release blocker and reclassifying to the admin.

[Jacob Walls <jacobtylerwalls@…>]

In 253f552c:

Fixed #36949 -- Improved RelatedFieldWidgetWrapper <label>s.

Regression in 4187da258fe212d494cb578a0bc2b52c4979ab95.

[Jacob Walls <jacobtylerwalls@…>]

In ea8e293f:

[6.0.x] Fixed #36949 -- Improved RelatedFieldWidgetWrapper <label>s.

Regression in 4187da258fe212d494cb578a0bc2b52c4979ab95.

Backport of 253f552c5809fa096116b601bd842ca4f3504860 from main.

[Jacob Walls <jacobtylerwalls@…>]

In 123fa3a3:

Refs #36949 -- Removed hardcoded pks in modeladmin tests.

[Jacob Walls <jacobtylerwalls@…>]

In ffc83c55:

[6.0.x] Refs #36949 -- Removed hardcoded pks in modeladmin tests.

Backport of 123fa3a3f38abdb73055acc9a2cbbe3537f9323a from main.