Opened 10 months ago
Closed 2 weeks ago
#35892 closed Cleanup/optimization (fixed)
Support Widget.use_fieldset in admin forms
Reported by: | Sarah Boyce | Owned by: | Antoliny |
---|---|---|---|
Component: | contrib.admin | Version: | 5.0 |
Severity: | Normal | Keywords: | accessibility |
Cc: | David Smith, Tom Carrick, Thibaud Colas, Antoliny | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Currently, the admin doesn't respect Widget.use_fieldset
When a widget has this set, the field should be rendered in a fieldset, ideally with a legend tag (or the fieldset using aria-labelledby
) and have aria-describedby
to associate the helptext to the fieldset
All admin widgets should be reviewed as to whether use_fieldset
should be True
See this PR discussion for context: https://github.com/django/django/pull/18742#issuecomment-2460108968
Change History (20)
comment:1 by , 10 months ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 10 months ago
Cc: | added |
---|---|
Owner: | set to |
Status: | new → assigned |
comment:3 by , 10 months ago
Has patch: | set |
---|
comment:4 by , 10 months ago
Patch needs improvement: | set |
---|
comment:5 by , 9 months ago
Cc: | removed |
---|---|
Owner: | removed |
Status: | assigned → new |
comment:6 by , 9 months ago
Cc: | added |
---|
follow-up: 8 comment:7 by , 9 months ago
Owner: | set to |
---|---|
Status: | new → assigned |
follow-up: 9 comment:8 by , 7 months ago
Replying to JakeWalson:
are you still working on this ticket? if your not can i work this ticket?
comment:9 by , 7 months ago
Replying to Antoliny:
Replying to JakeWalson:
are you still working on this ticket? if your not can i work this ticket?
I'm currently working on this ticket. Let me know if you need any updates or if there's anything specific you'd like to discuss!
comment:10 by , 6 weeks ago
Owner: | changed from | to
---|
comment:12 by , 5 weeks ago
Patch needs improvement: | unset |
---|
comment:13 by , 5 weeks ago
Patch needs improvement: | set |
---|
comment:14 by , 5 weeks ago
Patch needs improvement: | unset |
---|
comment:15 by , 4 weeks ago
Patch needs improvement: | set |
---|
comment:16 by , 4 weeks ago
Patch needs improvement: | unset |
---|
comment:17 by , 3 weeks ago
Patch needs improvement: | set |
---|
comment:18 by , 3 weeks ago
Patch needs improvement: | unset |
---|
comment:19 by , 3 weeks ago
Triage Stage: | Accepted → Ready for checkin |
---|
https://github.com/django/django/pull/18803