Opened 12 months ago

Closed 3 months ago

#35892 closed Cleanup/optimization (fixed)

Support Widget.use_fieldset in admin forms

Reported by: Sarah Boyce Owned by: Antoliny
Component: contrib.admin Version: 5.0
Severity: Normal Keywords: accessibility
Cc: David Smith, Tom Carrick, Thibaud Colas, Antoliny Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Currently, the admin doesn't respect ​Widget.use_fieldset

When a widget has this set, the field should be rendered in a fieldset, ideally with a legend tag (or the fieldset using aria-labelledby) and have aria-describedby to associate the helptext to the fieldset

All admin widgets should be reviewed as to whether use_fieldset should be True

See this PR discussion for context: ​https://github.com/django/django/pull/18742#issuecomment-2460108968

Change History (20)

comment:1 by Tom Carrick, 12 months ago

Triage Stage: Unreviewed → Accepted

comment:2 by SAI GANESH S, 12 months ago

Cc: SAI GANESH S added
Owner: set to SAI GANESH S
Status: new → assigned

comment:4 by Sarah Boyce, 12 months ago

Patch needs improvement: set

comment:5 by SAI GANESH S, 12 months ago

Cc: SAI GANESH S removed
Owner: SAI GANESH S removed
Status: assigned → new

comment:6 by Antoliny, 11 months ago

Cc: Antoliny added

comment:7 by JakeWalson, 11 months ago

Owner: set to JakeWalson
Status: new → assigned

in reply to:  7 ; comment:8 by Antoliny, 10 months ago

Replying to JakeWalson:
are you still working on this ticket? if your not can i work this ticket?

in reply to:  8 comment:9 by JakeWalson, 10 months ago

Replying to Antoliny:

Replying to JakeWalson:
are you still working on this ticket? if your not can i work this ticket?

I'm currently working on this ticket. Let me know if you need any updates or if there's anything specific you'd like to discuss!

comment:10 by Antoliny, 4 months ago

Owner: changed from JakeWalson to Antoliny

comment:12 by Antoliny, 4 months ago

Patch needs improvement: unset

comment:13 by Sarah Boyce, 4 months ago

Patch needs improvement: set

comment:14 by Antoliny, 4 months ago

Patch needs improvement: unset

comment:15 by Sarah Boyce, 3 months ago

Patch needs improvement: set

comment:16 by Antoliny, 3 months ago

Patch needs improvement: unset

comment:17 by Sarah Boyce, 3 months ago

Patch needs improvement: set

comment:18 by Antoliny, 3 months ago

Patch needs improvement: unset

comment:19 by Sarah Boyce, 3 months ago

Triage Stage: Accepted → Ready for checkin

comment:20 by Sarah Boyce <42296566+sarahboyce@…>, 3 months ago

Resolution: → fixed
Status: assigned → closed

In 4187da2:

Fixed #35892 -- Supported Widget.use_fieldset in admin forms.

Note: See TracTickets for help on using tickets.
Back to Top