Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#35003 closed Bug (fixed)

Incorrect margin for RTL languages

Reported by: Natalia Bidart Owned by: Tom Carrick
Component: contrib.admin Version: 4.2
Severity: Normal Keywords: rtl
Cc: Tom Carrick Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

While reviewing and debugging the PR for ticket #34995, I've noticed that some widgets and help text are not properly placed for RTL languages. See screenshots attached for more details.

Attachments (4)

django-admin-wrong-margin-rtl-4.2.png (188.9 KB ) - added by Natalia Bidart 3 months ago.
Example in Django 4.2
django-admin-wrong-left-margin-rtl.png (77.9 KB ) - added by Natalia Bidart 3 months ago.
Example in Django 5.0
django-admin-wrong-right-margin-rtl.png (156.3 KB ) - added by Natalia Bidart 3 months ago.
Other example Django 5.0
Screenshot_20231130_112450.png (24.7 KB ) - added by Mariusz Felisiak 3 months ago.

Download all attachments as: .zip

Change History (15)

by Natalia Bidart, 3 months ago

Example in Django 4.2

by Natalia Bidart, 3 months ago

Example in Django 5.0

by Natalia Bidart, 3 months ago

Other example Django 5.0

comment:1 by Natalia Bidart, 3 months ago

Cc: Tom Carrick added

comment:2 by Natalia Bidart, 3 months ago

Keywords: rtl added

comment:3 by Tom Carrick, 3 months ago

Owner: changed from nobody to Tom Carrick
Status: newassigned

comment:4 by Tom Carrick, 3 months ago

Has patch: set

comment:5 by Mariusz Felisiak, 3 months ago

Resolution: duplicate
Status: assignedclosed

This is exactly what I was trying to report in #34982. Marking as duplicate and reopening #34982.

comment:6 by Mariusz Felisiak, 3 months ago

Has patch: unset
Summary: Admin: incorrect margin for RTL languagesIncorrect margin for RTL languages

comment:7 by Mariusz Felisiak, 3 months ago

OK, it's about left, not right margin. Nevertheless we can treat this as a duplicate, IMO.

comment:8 by Mariusz Felisiak, 3 months ago

Resolution: duplicate
Severity: Release blockerNormal
Status: closednew
Triage Stage: UnreviewedAccepted

Reopening as it's related to #34982, but it's not a regression, left margins are there in Django 4.1 as well:

Last edited 3 months ago by Mariusz Felisiak (previous) (diff)

by Mariusz Felisiak, 3 months ago

comment:9 by Mariusz Felisiak, 3 months ago

Has patch: set
Triage Stage: AcceptedReady for checkin

comment:10 by GitHub <noreply@…>, 3 months ago

Resolution: fixed
Status: newclosed

In b34a4771:

Fixed #35003 -- Corrected margins in admin for RTL languages.

comment:11 by GitHub <noreply@…>, 3 months ago

In be06c39:

Refs #35003 -- Corrected "wide" form margins in admin for LTR languages.

Note: See TracTickets for help on using tickets.
Back to Top