Opened 5 months ago

Closed 5 months ago

#34835 closed Cleanup/optimization (fixed)

Use a `nav` element or `navigation` landmark for changelist filters

Reported by: Thibaud Colas Owned by: Lemuel Sta Ana
Component: contrib.admin Version: 4.2
Severity: Normal Keywords: accessibility, screen reader, landmarks
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description (last modified by Thibaud Colas)

Related: #34832, #34833, #34834. Changelist filters are a very useful way to navigate long lists of entries. The filters would be easier to reach for screen reader users if they were in a navigation landmark done with a <nav> element or role="navigation" attribute. Currently they are a <div id="changelist-filter">.

This element should be switched to a <nav>, and we should also add an aria-labelledby set to the id of <h2>Filter</h2> element within, so the navigation landmark has a distinct label.

Change History (13)

comment:1 by Thibaud Colas, 5 months ago

Description: modified (diff)

comment:2 by Thibaud Colas, 5 months ago

Description: modified (diff)

comment:3 by faizan2700, 5 months ago

Owner: changed from nobody to faizan2700
Status: newassigned

comment:4 by Mariusz Felisiak, 5 months ago

Easy pickings: set
Triage Stage: UnreviewedAccepted

comment:5 by Lemuel Sta Ana, 5 months ago

Hi @faizan2700, are you still actively working on the ticket?

comment:6 by Lemuel Sta Ana, 5 months ago

Owner: changed from faizan2700 to Lemuel Sta Ana

Reassigning/claiming ticket after about two weeks of inactivity.

comment:7 by Lemuel Sta Ana, 5 months ago

Has patch: set
Triage Stage: AcceptedReady for checkin

Hello. Please see below,

PR

Thanks,
Lem

comment:8 by Lemuel Sta Ana, 5 months ago

Needs tests: set

comment:9 by Mariusz Felisiak, 5 months ago

Triage Stage: Ready for checkinAccepted

Please don't mark your own patches as "Ready for checkin".

comment:10 by Lemuel Sta Ana, 5 months ago

Oops, apologies @Mariusz. I enabled the wrong flag. Will be mindful next time, thank you!

comment:11 by Mariusz Felisiak, 5 months ago

Needs documentation: set
Needs tests: unset

comment:12 by Mariusz Felisiak, 5 months ago

Needs documentation: unset
Triage Stage: AcceptedReady for checkin

comment:13 by Mariusz Felisiak <felisiak.mariusz@…>, 5 months ago

Resolution: fixed
Status: assignedclosed

In 357365a:

Fixed #34835 -- Made admin's changelist filters render in <nav> tag.

Note: See TracTickets for help on using tickets.
Back to Top