Opened 3 years ago
Closed 3 years ago
#34834 closed Cleanup/optimization (fixed)
Use `search` role for the admin changelist search form
| Reported by: | Thibaud Colas | Owned by: | Lemuel Sta Ana |
|---|---|---|---|
| Component: | contrib.admin | Version: | 4.2 |
| Severity: | Normal | Keywords: | accessibility, screen reader, landmarks |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
Related: #34832, #34833. Django’s ChangeListSearchForm and its search_form.html currently use <div id="toolbar"><form id="changelist-search" method="get"></form></div> markup for the form. It would be nice for screen reader users to use a role="search" on the form, so it’s explicitly identified as a search form when navigating the page by region.
In the future it would be even better to convert the wrapping toolbar div to use the search HTML element, but browser support isn’t there yet.
Change History (8)
comment:1 by , 3 years ago
comment:2 by , 3 years ago
| Easy pickings: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
faizan2700, you can assign yourself a ticket.
comment:5 by , 3 years ago
| Needs tests: | set |
|---|
comment:7 by , 3 years ago
| Needs tests: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
Note:
See TracTickets
for help on using tickets.
Please assign me this ticket. I understand what needs to be done.
My Introduction:
I have graduated from IIIT Pune in 2021. I am doing freelancing since college only, I have worked in ServiceNow and CleverTaps before currently I am working on my startup.