Opened 9 months ago

Closed 9 months ago

#34832 closed Cleanup/optimization (fixed)

Use `banner` landmark or `<header>` element for the admin header area

Reported by: Thibaud Colas Owned by: Sarah Abderemane
Component: contrib.admin Version: 4.2
Severity: Normal Keywords: accessibility, screen reader, landmarks
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description (last modified by Thibaud Colas)

Related: #34833. The Django admin uses a <div id="header"></div> for its header area. Switching this to a <header> tag or adding a role="banner" attribute to the div would help screen reader users navigate the interface – they would have an easier time bypassing the whole area when going through the page sequentially, and would also be able to jump straight to the header from any point on the page.

Usage of the correct HTML header tag is ideal, but might prove problematic if CSS was written with overly specific HTML elements. We can get the same benefits for screen reader users with role="banner".

---

See also recommendations to have all content in landmarks that this will help us address.

Change History (10)

comment:1 by Thibaud Colas, 9 months ago

Description: modified (diff)

comment:2 by Mariusz Felisiak, 9 months ago

Triage Stage: UnreviewedAccepted
Type: New featureCleanup/optimization

comment:3 by Thibaud Colas, 9 months ago

Description: modified (diff)

comment:4 by Mariusz Felisiak, 9 months ago

Easy pickings: set

comment:5 by faizan2700, 9 months ago

Please assign me this issue.

comment:6 by Sarah Abderemane, 9 months ago

Owner: changed from nobody to Sarah Abderemane
Status: newassigned

comment:7 by Sarah Abderemane, 9 months ago

Has patch: set

comment:8 by Mariusz Felisiak, 9 months ago

Needs documentation: set
Needs tests: set

comment:9 by Mariusz Felisiak, 9 months ago

Needs documentation: unset
Needs tests: unset
Triage Stage: AcceptedReady for checkin

comment:10 by Mariusz Felisiak <felisiak.mariusz@…>, 9 months ago

Resolution: fixed
Status: assignedclosed

In 814e7bc:

Fixed #34832 -- Made admin's header content render in <header> tag.

Header tag was changed to <header> get the landmark banner for
accessibility.

Note: See TracTickets for help on using tickets.
Back to Top