makemigrations --check generating migrations is inconsistent with other uses of --check

[Jacob Walls]

To script a check for missing migrations but without actually intending to create the migrations, it is necessary to use both --check and --dry-run, which is inconsistent with migrate --check and optimizemigration --check, which just exit (after possibly logging a bit).

I'm suggesting that makemigrations --check should just exit without making migrations.

The choice to write the migrations anyway was not discussed AFAICT on ticket:25604 or ​https://groups.google.com/g/django-developers/c/zczdY6c9KSg/m/ZXCXQsGDDAAJ.

Noticed when reading ​PR to adjust the documentation of migrate --check. I think the current documentation is silent on this question.

[Claude Paroz]

I think this makes sense.

[Jacob Walls]

​PR

[Mariusz Felisiak <felisiak.mariusz@…>]

In 80d38de5:

Fixed #34051 -- Made makemigrations --check exit before making migrations.

[Daniel Hahler]

I was using --check --dry-run to see missing migrations on CI already, which now becomes silent.

Would it make sense to have migrations still being written/printed in case --dry-run is used.

Or is there another option to get the desired behavior on CI?

(You could use --check first an in case of exiting with 1 use --dry-run alone, but I think the old behavior was good).

I am using also -v3 to make it very verbose - maybe that could be taken into consideration also.

[Daniel Hahler]

Oh, addressed/fixed in #34457 already.