Opened 2 years ago

Closed 2 years ago

#34052 closed Bug (fixed)

migrate --check still emits signals if database is up to date

Reported by: Jacob Walls Owned by: JunKi Yoon
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Jacob Walls)

pre_migrate and post_migrate signals are emitted for migrate --check, but only if the database is up-to-date.

A related side effect is that the logs also look like a like a real run, as it says "Operations to perform:" and "Running migrations:". The last sentence clarifies that nothing has been applied, but there is still the potential for a half-second of "what have I just done?".

% python manage.py migrate --check          
Operations to perform:
  Apply all migrations: admin, auth, contenttypes, sessions, social_django
Running migrations:
  No migrations to apply.

Change History (8)

comment:1 by Mariusz Felisiak, 2 years ago

Triage Stage: Unreviewed → Accepted

in reply to:  description comment:2 by JunKi Yoon, 2 years ago

Replying to Jacob Walls:

Can I try this ticket?

comment:3 by JunKi Yoon, 2 years ago

Owner: changed from nobody to JunKi Yoon
Status: new → assigned

comment:4 by JunKi Yoon, 2 years ago

Has patch: set

I added patch :)
​PR

comment:5 by Mariusz Felisiak, 2 years ago

Needs tests: set
Patch needs improvement: set

comment:6 by Jacob Walls, 2 years ago

Description: modified (diff)

comment:7 by Mariusz Felisiak, 2 years ago

Needs tests: unset
Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

Resolution: → fixed
Status: assigned → closed

In 1a7b690:

Fixed #34052 -- Made migrate --check don't emit signals and output when up to date.

Note: See TracTickets for help on using tickets.
Back to Top