Opened 18 years ago

Closed 17 years ago

#3224 closed enhancement (fixed)

[patch] small refactor of the response middleware invocation

Reported by: mihai_preda@… Owned by: nobody
Component: Core (Other) Version: dev
Severity: normal Keywords: handlers response middleware
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:How to create a pull request

Description

Factored the common code which invokes the response middleware out from WSGIHandler and ModPythonHandler and put it into BaseHandler.

Change History (9)

by mihai_preda@…, 18 years ago

Attachment: refactor-response-middleware.diff​ added

svn diff

by mihai_preda@…, 18 years ago

Attachment: resolver.diff​ added

[patch] refactoring: remove code duplication between core.resolvers and core.handlers.base: added method to build a resolver in resolvers.py.

by mihai_preda@…, 18 years ago

Attachment: build_url.diff​ added

refactor: extracted the build_url() function from middleware/common.py and put it into http.

comment:1 by Chris Beaven, 18 years ago

Triage Stage: Unreviewed → Ready for checkin

Seems

comment:2 by Chris Beaven, 18 years ago

... ready for checkin to me. Core can decide to push back if need be.

comment:3 by Adrian Holovaty, 18 years ago

I'll have a look at this...

comment:4 by Jacob, 18 years ago

Triage Stage: Ready for checkin → Design decision needed

I'm setting this back to design decision needed while Adrian looks at it; meanwhile, can someone explain *why* this is needed?

comment:5 by Ramiro Morales <rm0 _at_ gmx.net>, 18 years ago

The original submitter created #3228 afterwards and that enhancement depends on the refactoring implemented in this ticket.

comment:6 by James Bennett, 17 years ago

Resolution: → fixed
Status: new → closed

Closing in favor of #3240, which seems to be a more comprehensive refactoring of code common to both handlers.

Note: See TracTickets for help on using tickets.
Back to Top