Opened 10 years ago

Closed 9 years ago

#3224 closed enhancement (fixed)

[patch] small refactor of the response middleware invocation

Reported by: mihai_preda@… Owned by: nobody
Component: Core (Other) Version: master
Severity: normal Keywords: handlers response middleware
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Factored the common code which invokes the response middleware out from WSGIHandler and ModPythonHandler and put it into BaseHandler.

Attachments (3)

refactor-response-middleware.diff (2.5 KB) - added by mihai_preda@… 10 years ago.
svn diff
resolver.diff (1.4 KB) - added by mihai_preda@… 10 years ago.
[patch] refactoring: remove code duplication between core.resolvers and core.handlers.base: added method to build a resolver in resolvers.py.
build_url.diff (1.7 KB) - added by mihai_preda@… 10 years ago.
refactor: extracted the build_url() function from middleware/common.py and put it into http.

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by mihai_preda@…

svn diff

Changed 10 years ago by mihai_preda@…

Attachment: resolver.diff added

[patch] refactoring: remove code duplication between core.resolvers and core.handlers.base: added method to build a resolver in resolvers.py.

Changed 10 years ago by mihai_preda@…

Attachment: build_url.diff added

refactor: extracted the build_url() function from middleware/common.py and put it into http.

comment:1 Changed 10 years ago by Chris Beaven

Triage Stage: UnreviewedReady for checkin

Seems

comment:2 Changed 10 years ago by Chris Beaven

... ready for checkin to me. Core can decide to push back if need be.

comment:3 Changed 10 years ago by Adrian Holovaty

I'll have a look at this...

comment:4 Changed 10 years ago by Jacob

Triage Stage: Ready for checkinDesign decision needed

I'm setting this back to design decision needed while Adrian looks at it; meanwhile, can someone explain *why* this is needed?

comment:5 Changed 10 years ago by Ramiro Morales <rm0 _at_ gmx.net>

The original submitter created #3228 afterwards and that enhancement depends on the refactoring implemented in this ticket.

comment:6 Changed 9 years ago by James Bennett

Resolution: fixed
Status: newclosed

Closing in favor of #3240, which seems to be a more comprehensive refactoring of code common to both handlers.

Note: See TracTickets for help on using tickets.
Back to Top