Opened 17 years ago
Closed 17 years ago
#3224 closed enhancement (fixed)
[patch] small refactor of the response middleware invocation
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | normal | Keywords: | handlers response middleware |
| Cc: | Triage Stage: | Design decision needed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Factored the common code which invokes the response middleware out from WSGIHandler and ModPythonHandler and put it into BaseHandler.
Attachments (3)
Change History (9)
by , 17 years ago
| Attachment: | refactor-response-middleware.diff added |
|---|
by , 17 years ago
| Attachment: | resolver.diff added |
|---|
[patch] refactoring: remove code duplication between core.resolvers and core.handlers.base: added method to build a resolver in resolvers.py.
by , 17 years ago
| Attachment: | build_url.diff added |
|---|
refactor: extracted the build_url() function from middleware/common.py and put it into http.
comment:4 by , 17 years ago
| Triage Stage: | Ready for checkin → Design decision needed |
|---|
I'm setting this back to design decision needed while Adrian looks at it; meanwhile, can someone explain *why* this is needed?
comment:5 by , 17 years ago
The original submitter created #3228 afterwards and that enhancement depends on the refactoring implemented in this ticket.
comment:6 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Closing in favor of #3240, which seems to be a more comprehensive refactoring of code common to both handlers.
svn diff