Code

Opened 7 years ago

Closed 7 years ago

#3224 closed enhancement (fixed)

[patch] small refactor of the response middleware invocation

Reported by: mihai_preda@… Owned by: nobody
Component: Core (Other) Version: master
Severity: normal Keywords: handlers response middleware
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Factored the common code which invokes the response middleware out from WSGIHandler and ModPythonHandler and put it into BaseHandler.

Attachments (3)

refactor-response-middleware.diff (2.5 KB) - added by mihai_preda@… 7 years ago.
svn diff
resolver.diff (1.4 KB) - added by mihai_preda@… 7 years ago.
[patch] refactoring: remove code duplication between core.resolvers and core.handlers.base: added method to build a resolver in resolvers.py.
build_url.diff (1.7 KB) - added by mihai_preda@… 7 years ago.
refactor: extracted the build_url() function from middleware/common.py and put it into http.

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by mihai_preda@…

svn diff

Changed 7 years ago by mihai_preda@…

[patch] refactoring: remove code duplication between core.resolvers and core.handlers.base: added method to build a resolver in resolvers.py.

Changed 7 years ago by mihai_preda@…

refactor: extracted the build_url() function from middleware/common.py and put it into http.

comment:1 Changed 7 years ago by SmileyChris

  • Triage Stage changed from Unreviewed to Ready for checkin

Seems

comment:2 Changed 7 years ago by SmileyChris

... ready for checkin to me. Core can decide to push back if need be.

comment:3 Changed 7 years ago by adrian

I'll have a look at this...

comment:4 Changed 7 years ago by jacob

  • Triage Stage changed from Ready for checkin to Design decision needed

I'm setting this back to design decision needed while Adrian looks at it; meanwhile, can someone explain *why* this is needed?

comment:5 Changed 7 years ago by Ramiro Morales <rm0 _at_ gmx.net>

The original submitter created #3228 afterwards and that enhancement depends on the refactoring implemented in this ticket.

comment:6 Changed 7 years ago by ubernostrum

  • Resolution set to fixed
  • Status changed from new to closed

Closing in favor of #3240, which seems to be a more comprehensive refactoring of code common to both handlers.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.