Code

Opened 7 years ago

Closed 18 months ago

#3240 closed Bug (wontfix)

[patch]Django dispatcher misses some errors

Reported by: robin@… Owned by: nobody
Component: Core (Other) Version:
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

The django BaseHandler misses some errors and also the dispatch mechanism in modpython.py and wsgi.py also allows some errors to pass without being caught. I have a patch which attempts to fix this by

1) factorising out the code for 500 errors
2) moving the code that handles request middleware inside the try block in BaseHandler.get_resonse
3) factorising out the common dispatch code in modpython/wsgi.py into a BaseHandler.dispatch_request method and at the same time moving the response middleware into a try block in that method.
4) Use the BaseHandler.dispatch_request method in the ModPythonHandler/WSGIHandler call to replace common code.

Attachments (1)

base.py-4290.patch (8.2 KB) - added by robin@… 7 years ago.
patch against svn rev 4290

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by robin@…

patch against svn rev 4290

comment:1 Changed 7 years ago by robin@…

  • Summary changed from Django dispatcher misses some errors to [patch]Django dispatcher misses some errors

comment:2 Changed 7 years ago by Simon G. <dev@…>

  • Needs tests set
  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 7 years ago by ubernostrum

#3224 was a duplicate, but has an alternate implementation.

comment:4 Changed 4 years ago by adamnelson

  • Patch needs improvement set

Lots of changes in core/handlers/* since this patch was generated. It needs to be redone or perhaps just close the ticket since many other wsgi changes in the past 2 1/2 years have addressed deficiencies.

comment:5 Changed 3 years ago by lrekucki

  • Severity changed from normal to Normal
  • Type changed from defect to Bug

comment:6 Changed 2 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:7 Changed 2 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:8 Changed 18 months ago by aaugustin

  • Resolution set to wontfix
  • Status changed from new to closed

This ticket boils down to "here's a patch that does X", but the patch is way out of date, and X doesn't appear to be a common problem these days.

I don't think it's relevant any more.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.