Opened 17 years ago

Closed 12 years ago

#3240 closed Bug (wontfix)

[patch]Django dispatcher misses some errors

Reported by: robin@… Owned by: nobody
Component: Core (Other) Version:
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no


The django BaseHandler misses some errors and also the dispatch mechanism in and also allows some errors to pass without being caught. I have a patch which attempts to fix this by

1) factorising out the code for 500 errors
2) moving the code that handles request middleware inside the try block in BaseHandler.get_resonse
3) factorising out the common dispatch code in modpython/ into a BaseHandler.dispatch_request method and at the same time moving the response middleware into a try block in that method.
4) Use the BaseHandler.dispatch_request method in the ModPythonHandler/WSGIHandler call to replace common code.

Attachments (1) (8.2 KB ) - added by robin@… 17 years ago.
patch against svn rev 4290

Download all attachments as: .zip

Change History (9)

by robin@…, 17 years ago

Attachment: added

patch against svn rev 4290

comment:1 by robin@…, 17 years ago

Summary: Django dispatcher misses some errors[patch]Django dispatcher misses some errors

comment:2 by Simon G. <dev@…>, 17 years ago

Needs tests: set
Triage Stage: UnreviewedAccepted

comment:3 by James Bennett, 17 years ago

#3224 was a duplicate, but has an alternate implementation.

comment:4 by Adam Nelson, 14 years ago

Patch needs improvement: set

Lots of changes in core/handlers/* since this patch was generated. It needs to be redone or perhaps just close the ticket since many other wsgi changes in the past 2 1/2 years have addressed deficiencies.

comment:5 by Łukasz Rekucki, 13 years ago

Severity: normalNormal
Type: defectBug

comment:6 by Aymeric Augustin, 12 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:7 by Aymeric Augustin, 12 years ago

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:8 by Aymeric Augustin, 12 years ago

Resolution: wontfix
Status: newclosed

This ticket boils down to "here's a patch that does X", but the patch is way out of date, and X doesn't appear to be a common problem these days.

I don't think it's relevant any more.

Note: See TracTickets for help on using tickets.
Back to Top