Added SmartSlashMiddleware

[mihai_preda@…]

Implements a new way of 'append slash redirect', as described here:
​http://groups.google.com/group/django-developers/browse_thread/thread/d6ca6e1442658598

This patch requires some of the small refactorings from ticket #3224.

[mihai_preda@…]

SmartSlashMiddleware

[Malcolm Tredinnick]

I'm +0 on this, I guess. If we do use it, I think it should replace the existing APPEND_SLASH behaviour in CommonMiddleware, rather than becoming yet another option. It looks like it will work fairly smoothly in cases where APPEND_SLASH is currently being used. However, we will need the facility to disable it entirely, just as with APPEND_SLASH.

[gsf@…]

+1 on this patch replacing the existing APPEND_SLASH behavior. When I want to create a URL without an end slash, I shouldn't have to set a flag that breaks the admin interface. This patch puts the control of URLs where it should be -- in urls.py.

[Tai Lee]

+1 on this from me too. We should be able to define URLS that specifically do or do not end in a slash in urls.py, instead of having to choose one or the other and depending on files containing a period.

[andy-django@…]

+1 something like this would help me out a lot as well

[Simon G. <dev@…>]

Can one of the +1 commenters here want to fix up the current patch to trunk and implement Malcolm's suggestions above?

[andy-django@…]

Just checking - Malcolm's suggestions are to:

• port smartslash.diff to replace the existing APPEND_SLASH behaviour in CommonMiddleware?
• and to provide a patch for the docs?

Are there any backwards compatibility concerns about changing the current behaviour?

[andy-django@…]

Attached is a new patch to replace the existing APPEND_SLASH behaviour in CommonMiddleware, with unit tests.

If this looks ok, I'll do up a patch as well for the docs.

cheers,

[andy-django@…]

Just a quick note, smartslash-2.diff doesn't require the refactorings from ticket #3224.

[cablehead]

Gentle bump for review - we're using this patch over at ​http://rst2a.com - it'd be great to get something which has this effect back into trunk.

Cheers!

[Malcolm Tredinnick]

Two small problems before this can be checked in:

1. lines 59-69 (the exception message) won't work as expected. It's not a multi-line string. Wrap things in parentheses or something.
2. There should be a small documentation change to middleware.txt included to describe the new behaviour.

[Andy Gayton <andy-django@…>]

Hey Malcolm, I can get those things fixed up in the next couple of hours if you like.

Not sure if you have started on these fixes yet?

I did an svn up the other day, and got some conflicts on this patch. I think they need to be resolved as well.

[Malcolm Tredinnick]

Andy: I'm not fixing it, so go ahead.

[Andy Gayton <andy-django@…>]

changes since smartslash-2.diff was created

[Andy Gayton <andy-django@…>]

• damn sorry, overlooked the lines 59-69 the, i've added a test for it and fixed
• docs updated
• resolved conflicts
  • http.get_host(request) updated to request.get_host()
  • added test for #5762 and reapplied the urlquote change
• now making use of tests/urls.py which gets rid of the URLCONF hackery in the middleware test setUp

[Andy Gayton <andy-django@…>]

fixed typo in docs/middleware.txt

[Andy Gayton <andy-django@…>]

Hope this is good to go, any issues, just assign back to me.

[Malcolm Tredinnick]

(In [6852]) Fixed #3228 -- Added new APPEND_SLASH handling behaviour in the common middleware. Makes customisation a bit easier. Thanks, Mihai Preda and Andy Gayton.