Convert max_age to an int in set_cookie()

[Matt Johnson]

The max-age attribute of cookie is supposed to be an integer

​https://tools.ietf.org/html/rfc6265#page-20

I think it would be helpful to convert the max_age parameter of set_cookie() to an integer for the user. The benefit is simply that there are some cookie parsers that don't handle decimals gracefully. It's pretty easy to pass in a float without understanding the consequences. I spent a good chunk of time today trying to track down the problem.

Things to consider:

1. Do we only convert floats where the decimal part is 0? Or do we round or truncate?
2. If we can't successfully convert to an int, do we throw an exception, or just pass in the original value?

[Mariusz Felisiak]

Agreed, we should also mention this in ​docs, e.g.:

max_age should be an integer number of seconds, ...

Replying to Matt Johnson:

1. Do we only convert floats where the decimal part is 0? Or do we round or truncate?
2. If we can't successfully convert to an int, do we throw an exception, or just pass in the original value?

I would simply call int(max_age) without catching exceptions.

[Adam Johnson]

+1 to calling int()

[Mariusz Felisiak]

​PR

[Mariusz Felisiak <felisiak.mariusz@…>]

In d2d08c8:

Fixed #31982 -- Made HttpResponse.set_cookie() cast max_age argument to an integer.