Code

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#3031 closed defect (fixed)

date_based.archive_month includes too much

Reported by: ubernostrum Owned by: robh
Component: Generic views Version: master
Severity: normal Keywords: sprintsept14
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Per a report on the django-users list, it appears that the fix from #992, which was necessary at the time, is no longer necessary and now causes the archive_month view to include too many days.

Attachments (0)

Change History (6)

comment:1 Changed 7 years ago by pat.j.anderson@…

  • Version set to SVN

I'm not sure if what I have noticed in how date_based generic views work is related to this ticket, but I'll post my observation here, and see if you can confirm it.

I'm using the latest trunk (#5194) with python 2.5 on ubuntu feisty with MySQL 5.0.38.

'archive_month' includes 'Feb-01' if I query for the month of January, but 'archive_year' strips 'Jan-01', while the first day of other months is shown.

comment:2 Changed 7 years ago by Gary Wilson <gary.wilson@…>

  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 7 years ago by ubernostrum

Discussion on django-developers is here.

comment:4 Changed 7 years ago by robh

  • Keywords sprintsept14 added
  • Owner changed from nobody to robh
  • Status changed from new to assigned

This seems to have been fixed somewhere along the line, and I've written tests to prove it.

I haven't separated the patch out from #317 because it's starting to feel like they might as well be the same patch: "Provide basic tests for date-based generic views".

comment:5 Changed 7 years ago by robh

  • Resolution set to fixed
  • Status changed from assigned to closed

I've included patch for this in #5506 -- the particlar bug this ticket talks about is apparently no longer present, but the test in #5506 should make sure that it never comes back.

comment:6 Changed 6 years ago by patrick@…

i´m using rev 6023 and this issue doesn´t seem to be solved.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.