Opened 18 years ago

Closed 17 years ago

Last modified 17 years ago

#3031 closed defect (fixed)

date_based.archive_month includes too much

Reported by: James Bennett Owned by: robh
Component: Generic views Version: dev
Severity: normal Keywords: sprintsept14
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Per a report on the django-users list, it appears that the fix from #992, which was necessary at the time, is no longer necessary and now causes the archive_month view to include too many days.

Change History (6)

comment:1 by pat.j.anderson@…, 17 years ago

Version: SVN

I'm not sure if what I have noticed in how date_based generic views work is related to this ticket, but I'll post my observation here, and see if you can confirm it.

I'm using the latest trunk (#5194) with python 2.5 on ubuntu feisty with MySQL 5.0.38.

'archive_month' includes 'Feb-01' if I query for the month of January, but 'archive_year' strips 'Jan-01', while the first day of other months is shown.

comment:2 by Gary Wilson <gary.wilson@…>, 17 years ago

Triage Stage: UnreviewedAccepted

comment:3 by James Bennett, 17 years ago

Discussion on django-developers is here.

comment:4 by robh, 17 years ago

Keywords: sprintsept14 added
Owner: changed from nobody to robh
Status: newassigned

This seems to have been fixed somewhere along the line, and I've written tests to prove it.

I haven't separated the patch out from #317 because it's starting to feel like they might as well be the same patch: "Provide basic tests for date-based generic views".

comment:5 by robh, 17 years ago

Resolution: fixed
Status: assignedclosed

I've included patch for this in #5506 -- the particlar bug this ticket talks about is apparently no longer present, but the test in #5506 should make sure that it never comes back.

comment:6 by patrick@…, 17 years ago

i´m using rev 6023 and this issue doesn´t seem to be solved.

Note: See TracTickets for help on using tickets.
Back to Top