Opened 8 years ago

Closed 8 years ago

#5506 closed (fixed)

Add some tests for Generic views

Reported by: robh Owned by: russellm
Component: Generic views Version: master
Severity: Keywords: sprintsept14
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This sprint has seen a few tests being written for generic views, where previously there were none.

I've worked on #391 and #3031 and after testing found that they are both "worksforme".
There's also #1282 and #5494, which changed actual code.

All of these have used the TestClient to test the views, which appears to be the most practical option.

Attachments (1)

5506.diff (6.9 KB) - added by robh 8 years ago.
Tests for #391 (object_detail can't find 'today') and #3031 (archive_month includes too much)

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by robh

Tests for #391 (object_detail can't find 'today') and #3031 (archive_month includes too much)

comment:1 Changed 8 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from [patch] Generic views have no testing to Add some tests for Generic views
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 8 years ago by ubernostrum

See also #3689.

comment:3 Changed 8 years ago by russellm

  • Owner changed from nobody to russellm

I added the start of a view-testing regression test in [6370]; this one is next on my list.

comment:4 Changed 8 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [6374]) Fixed #5506 -- Added some basic tests for date-based generic views. Thanks to robh for the original patch.

Note: See TracTickets for help on using tickets.
Back to Top