Opened 7 years ago

Closed 7 years ago

#27346 closed Cleanup/optimization (fixed)

Stop setting the Content-Length header in ConditionalGetMiddleware

Reported by: Kevin Christopher Henry Owned by: Adam Malinowski
Component: HTTP handling Version: 1.10
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

With #5897 we started setting Content-Length in CommonMiddleware. With #26447 we started moving conditional request handling out of CommonMiddleware and into ConditionalGetMiddleware. This separation of concerns is a good thing. Setting Content-Length doesn't have anything to do with conditional requests, and I think it can be removed now that we have CommonMiddleware as the standard place to set it.

Change History (10)

comment:1 by Tim Graham, 7 years ago

Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization

It was discussed briefly when adding Content-Length to CommonMiddleware. We didn't see much advantage to removing it at the time as ConditionalGetMiddleware might be used without CommonMiddleware. I don't have a strong feeling about it though.

comment:2 by Aleksandr Sobolev, 7 years ago

Owner: changed from nobody to Aleksandr Sobolev
Status: newassigned

comment:3 by Martino Pizzol, 7 years ago

Owner: changed from Aleksandr Sobolev to Martino Pizzol

comment:4 by Martino Pizzol, 7 years ago

Owner: Martino Pizzol removed
Status: assignednew

comment:5 by Adam Malinowski, 7 years ago

Owner: set to Adam Malinowski
Status: newassigned

comment:6 by Adam Malinowski, 7 years ago

Has patch: set
Last edited 7 years ago by Simon Charette (previous) (diff)

comment:7 by Simon Charette, 7 years ago

Patch needs improvement: set

comment:8 by Adam Malinowski, 7 years ago

Patch needs improvement: unset

comment:9 by Tim Graham, 7 years ago

Triage Stage: AcceptedReady for checkin

comment:10 by Tim Graham <timograham@…>, 7 years ago

Resolution: fixed
Status: assignedclosed

In 37809b89:

Fixed #27346 -- Stopped setting the Content-Length header in ConditionalGetMiddleware.

Note: See TracTickets for help on using tickets.
Back to Top