Opened 8 years ago

Closed 8 years ago

#27345 closed Cleanup/optimization (fixed)

Stop setting the Date header in ConditionalGetMiddleware

Reported by: Kevin Christopher Henry Owned by: nobody
Component: HTTP handling Version: 1.10
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

This code, dating back to 2005, doesn't seem to serve any purpose at this time. The Date header is actually required on all responses, and will be provided by the server. This is the only place in the code base where the Date header is used.

This is documented behavior, but I think it can be removed without a deprecation cycle since any affected response will continue to have a Date header set by the server.

Change History (2)

comment:1 by Tim Graham, 8 years ago

Has patch: set
Triage Stage: Unreviewed → Accepted

Seems okay to me. ​PR

comment:2 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: new → closed

In 61f9243:

Fixed #27345 -- Stopped setting the Date header in ConditionalGetMiddleware.

Note: See TracTickets for help on using tickets.
Back to Top