Deprecate USE_ETAGS setting in favor of ConditionalGetMiddleware unconditionally setting an ETag
In my opinion this setting is not needed (any more)
- Conditional-Get handling can happen in the ConditionalGetMiddleware, not in CommonMiddleware any more
- using or not using the middleware is (nearly) the same as setting USE_ETAGS or not
- ETag Calculation can happen also in the middleware
this also will fix a problem when you use the GZipMiddleware in combination with the Conditional-Get handling in CommonMiddleware.
Open questions for me:
- ConditionalGetMiddleware also handles Last-Modified/If-Modified-Since , which CommonMiddleware didn't. I don't see a problem in throwing them together and activating/deactivating them together. You?
Change History
(8)
Has patch: |
set
|
Triage Stage: |
Unreviewed → Accepted
|
Patch needs improvement: |
set
|
Component: |
Uncategorized → HTTP handling
|
Description: |
modified (diff)
|
Patch needs improvement: |
unset
|
Summary: |
Remove USE_ETAGS setting → Deprecate USE_ETAGS setting in favor of ConditionalGetMiddleware unconditionally setting an ETag
|
Cc: |
k@… added
|
Triage Stage: |
Accepted → Ready for checkin
|
Resolution: |
→ fixed
|
Status: |
new → closed
|
(after some discussions here at the DjangoCon springs I've just set the triage state :) )