UserCreationForm isn't using password_validators_help_text_html

[Adam]

Unlike SetPasswordForm and AdminPasswordChangeForm, UserCreationForm is not using password_validators_help_text_html. I think this was probably accidentally left out of #25052. This means that the "Add user" form at /admin/auth/user/add/ provides no indication of what the password requirements are unless you provide a password that does not pass validation. Even then, it doesn't list what all of the password requirements are.

I tried adding help_text=password_validation.password_validators_help_text_html() to the UserCreationForm form's password1 field, but the CSS didn't work well with this (see the attached screen shot), so now I'm submitting this ticket.

[Sasha Gaevsky]

Replying to timgraham:

Could you please submit empty "Add user" and "Password change" forms in the admin?
There might be also another styling issue.

[Sasha Gaevsky]

Found incorrect indent for lists in the wide fieldsets - fixed it too.

​PR

[Tim Graham]

I'm not sure about the proposal on the pull request to change <p> tags to <span> in order to allow help_text to contain <ul>. This might be a bit disruptive for anyone extending the admin with custom markup or CSS. I don't have a good solution in mind but suggested to write to the DevelopersMailingList to get feedback on this before we proceed with it. Marking "Patch needs improvement" as an indication of that need.

[Sasha Gaevsky]

Asked about this in ​mailing list.

[Tim Graham <timograham@…>]

In 536db42:

Fixed #26097 -- Added password_validators_help_text_html to UserCreationForm.