#23929 closed New feature (fixed)
More tests for create_default_site
| Reported by: | Wojtek Ruszczewski | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.sites | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Change History (5)
comment:1 by , 11 years ago
| Has patch: | set |
|---|---|
| Patch needs improvement: | set |
comment:2 by , 11 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:3 by , 11 years ago
| Patch needs improvement: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
comment:4 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
The patch by ticket (some guessing about the problems):
clear_cachestatement, that's probably not needed any longer, because apre_savesignal clearing the cache was added in the meantime (the test the ticket refers to can be found here; removing the statement doesn't seem to cause any failures now);allow_migratecondition is what is needed currently;SitesFrameworkTests.setUp), the test still fails with PostgreSQL if you remove the sequence resetting part increate_default_site.Some cleanup of the patch is needed -- I suspect that removing the
clear_cachestatement and replacing 1 with SITE_ID should go as separate tickets.