Opened 17 years ago

Closed 17 years ago

Last modified 10 years ago

#7514 closed (fixed)

Test failure after r7716

Reported by: Alex Gaynor Owned by: Marc Fargas
Component: Contrib apps Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I am getting a test failure since r7716, the buildbot confirms it: ​http://buildbot.djangoproject.com/trunk%202.5%20sqlite/builds/498/step-test/0

Change History (7)

comment:1 by Marc Fargas, 17 years ago

The error (which ​was discovered early) can be tracked down to the SITE_CACHE (defined in contrib/sites/models.py).

Clearing this cache on a post_syncdb signal solves this problem.

I'll attach a patch in a moment. Also will file a bug discovered in the way ;)

by Marc Fargas, 17 years ago

Attachment: 7514.diff​ added

Clear SITE_CACHE on syncdb.

comment:2 by Marc Fargas, 17 years ago

Has patch: set
Triage Stage: Unreviewed → Ready for checkin

Attached a fix, also available on my git repo.

comment:3 by Marc Fargas, 17 years ago

Owner: changed from nobody to Marc Fargas
Status: new → assigned

comment:4 by Marc Fargas, 17 years ago

Component: Uncategorized → Contrib apps

comment:5 by Russell Keith-Magee, 17 years ago

Resolution: → fixed
Status: assigned → closed

(In [7723]) Fixed #7514 -- Added code to clear the site cache on sync. This shouldn't have any effect on regular usage, but it does correct an error in the test suite. Thanks to Marc Fargas for the fix.

comment:6 by Tim Graham <timograham@…>, 10 years ago

In 777b4c26e343d07764a35132462e92c07e4b0aec:

Removed a clear_cache statement in contrib.sites.create_default_site.

It was originally added to fix a test (refs #7514); but Site now has a
pre_save signal handler (refs #19698) to clear the cache which makes
this call redundant.

Note: See TracTickets for help on using tickets.
Back to Top