Opened 8 years ago

Closed 8 years ago

Last modified 21 months ago

#7514 closed (fixed)

Test failure after r7716

Reported by: Alex Owned by: telenieko
Component: Contrib apps Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


I am getting a test failure since r7716, the buildbot confirms it:

Attachments (1)

7514.diff (524 bytes) - added by telenieko 8 years ago.
Clear SITE_CACHE on syncdb.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by telenieko

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

The error (which was discovered early) can be tracked down to the SITE_CACHE (defined in contrib/sites/

Clearing this cache on a post_syncdb signal solves this problem.

I'll attach a patch in a moment. Also will file a bug discovered in the way ;)

Changed 8 years ago by telenieko

Clear SITE_CACHE on syncdb.

comment:2 Changed 8 years ago by telenieko

  • Has patch set
  • Triage Stage changed from Unreviewed to Ready for checkin

Attached a fix, also available on my git repo.

comment:3 Changed 8 years ago by telenieko

  • Owner changed from nobody to telenieko
  • Status changed from new to assigned

comment:4 Changed 8 years ago by telenieko

  • Component changed from Uncategorized to Contrib apps

comment:5 Changed 8 years ago by russellm

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7723]) Fixed #7514 -- Added code to clear the site cache on sync. This shouldn't have any effect on regular usage, but it does correct an error in the test suite. Thanks to Marc Fargas for the fix.

comment:6 Changed 21 months ago by Tim Graham <timograham@…>

In 777b4c26e343d07764a35132462e92c07e4b0aec:

Removed a clear_cache statement in contrib.sites.create_default_site.

It was originally added to fix a test (refs #7514); but Site now has a
pre_save signal handler (refs #19698) to clear the cache which makes
this call redundant.

Note: See TracTickets for help on using tickets.
Back to Top