Deleting Sites through a manager does not clear cache

[ddavies@…]

When you delete a Site instance, i.e. Site.objects.get_current().delete(), the cache is cleared. However, if you delete all sites, Site.objects.all().delete(), the cache is not cleared.

    def test_delete_all_sites_clears_cache(self):
        """
        When all site objects are deleted the cache should  also
        be cleared and get_current should raise a DoesNotExist
        """
        from django.contrib.sites.models import Site
        site = Site.objects.create(domain='example.com', name='test')
        self.assertIsInstance(Site.objects.get_current(), Site)
        Site.objects.all().delete()
        self.assertRaises(Site.DoesNotExist, Site.objects.get_current)

[Claude Paroz]

The delete() method of the Site class should probably be replaced by a pre_delete signal.

[ddavies@…]

Patched to make delete() a pre_delete signal

[ddavies@…]

Refactored the previous patch as Site no longer needed a save() method either.

[ddavies@…]

Sorry, forgot to take out decorator on previous patch.

[Serdar Dalgic]

Hi;

I've rebased the patch, checked and fixed some pep8 violations.

I've also moved the function to the end of the file, instead of writing in after the class Site.

The patch is ready for checking. I've also changed the version to 1.5-rc1, because it is a bug. If you don't agree, you can change it.

This is my first work in Django trac, so sorry if I did something wrong :) Thanks for your help, any comments are appreciated.

[DHessing]

You can't mark your own patches as Ready For Check-in and version is used for when the bug was identified. Otherwise the patch looks fine! Leaving as RFC.

[Claude Paroz <claude@…>]

In 98ab8e8876e130de24e1de9473a4db716d5b002e:

Fixed #19698 -- Cleared sites cache with signals

Thanks ddavies at nomensa.com for the report and the patch and
serdaroncode for reviewing the patch.

[Tim Graham <timograham@…>]

In 777b4c26e343d07764a35132462e92c07e4b0aec:

Removed a clear_cache statement in contrib.sites.create_default_site.

It was originally added to fix a test (refs #7514); but Site now has a
pre_save signal handler (refs #19698) to clear the cache which makes
this call redundant.