Opened 10 years ago
Closed 10 years ago
#23686 closed Bug (fixed)
Tweak color output of the system check framework
| Reported by: | Loic Bistuer | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Management commands) | Version: | 1.7 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
See attached pictures.
Now that we have both warning and errors I suggest that the first line ("System check identified some issues:") should be more neutral, i.e. white.
Also the red color of the first line leaked onto the first heading.
Attachments (2)
Change History (6)
by , 10 years ago
| Attachment: | change.png added |
|---|
by , 10 years ago
| Attachment: | leakage.png added |
|---|
comment:1 by , 10 years ago
| Component: | Uncategorized → Core (Management commands) |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Type: | Uncategorized → Bug |
comment:2 by , 10 years ago
| Has patch: | set |
|---|---|
| Patch needs improvement: | set |
comment:3 by , 10 years ago
| Patch needs improvement: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
comment:4 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
So far I've got https://github.com/django/django/pull/3391.
It has proven more challenging than expected and the duplication of
""System check identified some issues:\n"is not ideal but that's the least invasive I could find.This PR also addresses #23663 (still missing a test for it), and IMO provides a better approach to fixing #23107 (refs https://code.djangoproject.com/ticket/23107#comment:13).