--no-color option won't work for output of runserver command

[Hiroki Kiyohara]

The --no-color option won't work for output of runserver command.

python manage.py runserver --no-color
...

[26/Jul/2014 15:01:07] "GET / HTTP/1.1" 500 85001  # Colored

Ticket for --no-color feature did not include about WSGIServer https://code.djangoproject.com/ticket/19877
And, output of the WSGIServer will be colorized.
(actually output of the management command won't be colorized).

[Hiroki Kiyohara]

Attached a patch to fix the behaviour.
I'll try to write tests and send PR (after Accepted).

It seems difficult to write test (Running debug server with --no-color option and checking the log).
So If you have some idea, please share.

[Areski Belaid]

I tried the patch to add a review and it didn't worked for me, so I made the following pull request:
​https://github.com/django/django/pull/2989

I think this need a more advanced Django dev to review it and maybe put us in the right direction.

[Hiroki Kiyohara]

@areski Thanks for your patch. Your solution is direct and seems good. I deassign from this patch.

[Areski Belaid]

I'm taking a much more simplistic approach to solve this, same as mentioned in the original patch but with a correction.
​https://github.com/django/django/pull/2998

[Tim Graham <timograham@…>]

In 67d7da5fb9498b811f0168f5df2308ad4743027f:

Fixed #23107 -- Made runserver output respect --no-color.

[Tim Graham <timograham@…>]

In 7cb4a82eaf2c6b59a80699ae91b63180eb8a47ef:

[1.7.x] Fixed #23107 -- Made runserver output respect --no-color.

Backport of 67d7da5fb9 from master

[Hiroki Kiyohara]

Thank you guys.
I think it's better to credit @timo and me on the commit log.
​https://docs.djangoproject.com/en/1.7/internals/contributing/committing-code/#committing-guidelines

[Tim Graham]

Sorry, I forgot to add that.

[Loic Bistuer]

I don't think modifying the environment is an appropriate fix, if you use call_command(no_color=True), every other call_command() won't have color. I'm in favor of a revert.

[Loic Bistuer]

Sadly it doesn't seem that we have any other ways than the environment to reach WSGIRequestHandler. In ​https://github.com/django/django/pull/3391 I limit the change of environment to the runserver command which is IMO acceptable considering this command runs forever.

[Loic Bistuer <loic.bistuer@…>]

In c34e13e17c664ea43b85572428bcf74c7509db3f:

Fixed #23107 -- Made runserver output respect --no-color.

This commit reverts 67d7da5fb9498b811f0168f5df2308ad4743027f.

The previous fix changed the environment globally, which meant
that any call to call_command(no_color=True) prevented further
call_command with color.

This fix still relies on the environment because it's currently the only
way to reach WSGIRequestHandler, but it's now limited to the runserver
command. This seems an acceptable compromise considering runserver runs
indefinitely.

Thanks Tim Graham for the review.