#23685 closed Bug (fixed)
System check framework runs multiple times
Reported by: | Loic Bistuer | Owned by: | Claude Paroz |
---|---|---|---|
Component: | Core (Management commands) | Version: | 1.7 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Every time a command calls call_command()
without skip_checks=True
, system checks run multiple times.
testserver
:
https://github.com/django/django/blob/c974b7bbe0abddd9796c65a23b68e61ba75cb5a3/django/core/management/commands/testserver.py#L30
https://github.com/django/django/blob/c974b7bbe0abddd9796c65a23b68e61ba75cb5a3/django/core/management/commands/testserver.py#L40
This is similar to #23650 which addressed the issue for migrate
.
Change History (9)
comment:1 by , 10 years ago
Component: | Uncategorized → Core (Management commands) |
---|
comment:3 by , 10 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:5 by , 10 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
comment:6 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:8 by , 10 years ago
Thnx for a fix.
Will this be backported to 1.7.X or should I use master branch?
comment:9 by , 10 years ago
We don't plan to backport this on 1.7.x because it didn't seem to be a blocker/crasher, but more an annoyance. If you have a use case where this is a more serious problem, we could reconsider.
Should we systematically set skip_checks to True in
call_command
? I think that we can legitimately assume that when a management command is called throughcall_command
, either the checks have already passed... or it is too late!