Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#23685 closed Bug (fixed)

System check framework runs multiple times

Reported by: Loic Bistuer Owned by: Claude Paroz
Component: Core (Management commands) Version: 1.7
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Change History (9)

comment:1 by Claude Paroz, 10 years ago

Component: UncategorizedCore (Management commands)

Should we systematically set skip_checks to True in call_command? I think that we can legitimately assume that when a management command is called through call_command, either the checks have already passed... or it is too late!

comment:2 by Loic Bistuer, 10 years ago

+1 for making skip_checks=True the default for call_command.

comment:3 by Claude Paroz, 10 years ago

Owner: changed from nobody to Claude Paroz
Status: newassigned

comment:5 by Tim Graham, 10 years ago

Triage Stage: AcceptedReady for checkin

comment:6 by Claude Paroz <claude@…>, 10 years ago

Resolution: fixed
Status: assignedclosed

In 685edab9da89b54e3e0e7bbc1c9f8b33d3f45969:

Fixed #23685 -- Made call_command skip checks by default

Thanks Loic Bistuer for the report/review and Tim Graham for the
review.

comment:7 by Claude Paroz <claude@…>, 10 years ago

In bbc3505ef81768aa2afac8f73e6d45b5e8000c55:

Removed unneeded override_system_checks

Refs #23685.

comment:8 by Ilya Baryshev, 10 years ago

Thnx for a fix.
Will this be backported to 1.7.X or should I use master branch?

comment:9 by Claude Paroz, 10 years ago

We don't plan to backport this on 1.7.x because it didn't seem to be a blocker/crasher, but more an annoyance. If you have a use case where this is a more serious problem, we could reconsider.

Note: See TracTickets for help on using tickets.
Back to Top