Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#23650 closed Bug (fixed)

System checks framework runs 3 times while performing manage.py test

Reported by: Ilya Baryshev Owned by: nobody
Component: Core (System checks) Version: 1.7
Severity: Normal Keywords: tests checks
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I think running checks only one time during tests is better.

First, mange.py ​migrate performs it,
then manage.py ​flush,
and lastly ​loaddata.

If you happen to have output by checks framework, it will be repeated 3 times.

Change History (6)

comment:1 by Claude Paroz, 10 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Tim Graham, 10 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Claude Paroz <claude@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In 8d6e1afe0be0570253a508f43e2ef89ae640984e:

Fixed #23650 -- Prevented migrate from calling checks 3 times

Thanks Ilya Baryshev for the report and Tim Graham for the review.

comment:5 by Loic Bistuer <loic.bistuer@…>, 10 years ago

In ec8a2e3b0787a3027cd0a0954a8637fc9bd6a5f3:

Prevented syncdb from calling system checks multiple times. Refs #23650.

comment:6 by Claude Paroz <claude@…>, 10 years ago

In 6d11bb102dd6876a936297c1ee8cddbaca22eee3:

Revert "Fixed #23650 -- Prevented migrate from calling checks 3 times"

This reverts commit 8d6e1afe0be0570253a508f43e2ef89ae640984e.
call_command now always set skip_checks to True (tested in
user_commands).

Note: See TracTickets for help on using tickets.
Back to Top